Message-ID: <53602B84.1020304@mit.edu>
Date: Tue, 29 Apr 2014 15:45:24 -0700
From: Andy Lutomirski <luto@amacapital.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Serge Hallyn <serge.hallyn@ubuntu.com>, Marian Marinov <mm@1h.com>
CC: containers@lists.linux-foundation.org, "Ted Ts'o" <tytso@mit.edu>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        lxc-devel <lxc-devel@lists.sourceforge.net>
Subject: Re: ioctl CAP_LINUX_IMMUTABLE is checked in the wrong namespace
References: <535FADDA.2070803@1h.com> <20140429183534.GB19325@thunk.org>	<20140429185251.GA27969@ubuntumail> <53601E5B.5050004@1h.com>	<20140429220234.GC28410@ubuntumail> <536026B3.1020905@1h.com> <20140429222913.GD28410@ubuntumail>
In-Reply-To: <20140429222913.GD28410@ubuntumail>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 04/29/2014 03:29 PM, Serge Hallyn wrote:
> Quoting Marian Marinov (mm-108MBtLGafw@public.gmane.org):
>> On 04/30/2014 01:02 AM, Serge Hallyn wrote:
>>> Quoting Marian Marinov (mm-108MBtLGafw@public.gmane.org):
>>>> On 04/29/2014 09:52 PM, Serge Hallyn wrote:
>>>>> Quoting Theodore Ts'o (tytso-3s7WtUTddSA@public.gmane.org):
>>>>>> On Tue, Apr 29, 2014 at 04:49:14PM +0300, Marian Marinov wrote:
>>>>>>>
>>>>>>> I'm proposing a fix to this, by replacing the capable(CAP_LINUX_IMMUTABLE)
>>>>>>> check with ns_capable(current_cred()->user_ns, CAP_LINUX_IMMUTABLE).
>>>>>>
>>>>>> Um, wouldn't it be better to simply fix the capable() function?
>>>>>>
>>>>>> /**
>>>>>>  * capable - Determine if the current task has a superior capability in effect
>>>>>>  * @cap: The capability to be tested for
>>>>>>  *
>>>>>>  * Return true if the current task has the given superior capability currently
>>>>>>  * available for use, false if not.
>>>>>>  *
>>>>>>  * This sets PF_SUPERPRIV on the task if the capability is available on the
>>>>>>  * assumption that it's about to be used.
>>>>>>  */
>>>>>> bool capable(int cap)
>>>>>> {
>>>>>> 	return ns_capable(&init_user_ns, cap);
>>>>>> }
>>>>>> EXPORT_SYMBOL(capable);
>>>>>>
>>>>>> The documentation states that it is for "the current task", and I
>>>>>> can't imagine any use case, where user namespaces are in effect, where
>>>>>> using init_user_ns would ever make sense.
>>>>>
>>>>> the init_user_ns represents the user_ns owning the object, not the
>>>>> subject.
>>>>>
>>>>> The patch by Marian is wrong.  Anyone can do 'clone(CLONE_NEWUSER)',
>>>>> setuid(0), execve, and end up satisfying 'ns_capable(current_cred()->userns,
>>>>> CAP_SYS_IMMUTABLE)' by definition.
>>>>>
>>>>> So NACK to that particular patch.  I'm not sure, but IIUC it should be
>>>>> safe to check against the userns owning the inode?
>>>>>
>>>>
>>>> So what you are proposing is to replace 'ns_capable(current_cred()->userns, CAP_SYS_IMMUTABLE)' with
>>>> 'inode_capable(inode, CAP_SYS_IMMUTABLE)' ?
>>>>
>>>> I agree that this is more sane.
>>>
>>> Right, and I think the two operations you're looking at seem sane
>>> to allow.
>>
>> If you are ok with this patch, I will fix all file systems and send patches.
> 
> Sounds good, thanks.
> 
>> Signed-off-by: Marian Marinov <mm-NV7Lj0SOnH0@public.gmane.org>
> 
> Acked-by: Serge E. Hallyn <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>

Wait, what?

Inodes aren't owned by user namespaces; they're owned by users.  And any
user can arrange to have a user namespace in which they pass an
inode_capable check on any inode that they own.

Presumably there's a reason that CAP_SYS_IMMUTABLE is needed.  If this
gets merged, then it would be better to just drop CAP_SYS_IMMUTABLE
entirely.

Nacked-by: Andy Lutomirski <luto@amacapital.net>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/