Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757768AbaD3GhZ (ORCPT ); Wed, 30 Apr 2014 02:37:25 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:63690 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752391AbaD3GhV (ORCPT ); Wed, 30 Apr 2014 02:37:21 -0400 MIME-Version: 1.0 In-Reply-To: <5345333D.4080505@saftware.de> References: <1396967856-27470-1-git-send-email-t.stanislaws@samsung.com> <1396967856-27470-2-git-send-email-t.stanislaws@samsung.com> <534506B1.4040908@samsung.com> <5345333D.4080505@saftware.de> Date: Wed, 30 Apr 2014 12:07:19 +0530 Message-ID: Subject: Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver From: Rahul Sharma To: Andreas Oberritter Cc: Andrzej Hajda , Tomasz Stanislawski , "linux-kernel@vger.kernel.org" , linux-samsung-soc , "devicetree@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Kukjin Kim , Kishon Vijay Abraham I , Kyungmin Park , Rob Herring , Grant Likely , Sylwester Nawrocki , Rahul Sharma , sunil joshi Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz, I have tested your patches for exynos5250 and 5420. Works fine. Are you planning to post v3? If you want I can share hand with you for v3. Regards, Rahul Sharma On 9 April 2014 17:17, Andreas Oberritter wrote: > Hello Andrzej, > > On 09.04.2014 10:37, Andrzej Hajda wrote: >>> +static int exynos_phy_probe(struct platform_device *pdev) >>> +{ >>> + const struct of_device_id *of_id = of_match_device( >>> + of_match_ptr(exynos_phy_of_match), &pdev->dev); >>> + const u32 *offsets = of_id->data; >>> + int count; >>> + struct device *dev = &pdev->dev; >>> + struct phy **phys; >>> + struct resource *res; >>> + void __iomem *regs; >>> + int i; >>> + struct phy_provider *phy_provider; >>> + >>> + /* count number of phys to create */ >>> + for (count = 0; offsets[count] != ~0; ++count) >>> + ; >> >> count = ARRAY_SIZE(offsets) - 1; > > u32 *offsets is not an array. > > Regards, > Andreas > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/