Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758174AbaD3JVk (ORCPT ); Wed, 30 Apr 2014 05:21:40 -0400 Received: from casper.infradead.org ([85.118.1.10]:34905 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbaD3JVj (ORCPT ); Wed, 30 Apr 2014 05:21:39 -0400 Date: Wed, 30 Apr 2014 11:21:36 +0200 From: Peter Zijlstra To: Davidlohr Bueso Cc: Ingo Molnar , Andrew Morton , Linus Torvalds , Tim Chen , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Rik van Riel , Peter Hurley , Thomas Gleixner , "Paul E.McKenney" , Aswin Chandramouleeswaran , "Norton, Scott J" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rwsem: Support optimistic spinning Message-ID: <20140430092136.GD11096@twins.programming.kicks-ass.net> References: <1398205166.6345.7.camel@buesod1.americas.hpqcorp.net> <1398722941.25549.16.camel@buesod1.americas.hpqcorp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398722941.25549.16.camel@buesod1.americas.hpqcorp.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 28, 2014 at 03:09:01PM -0700, Davidlohr Bueso wrote: > +#ifdef CONFIG_SMP > +#else > +static bool rwsem_optimistic_spin(struct rw_semaphore *sem) > +{ > + return false; > +} > +#endif On the mutex side we guard this with MUTEX_SPIN_ON_OWNER, do we want to use that here too? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/