Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964891AbaD3LtK (ORCPT ); Wed, 30 Apr 2014 07:49:10 -0400 Received: from fw-tnat.austin.arm.com ([217.140.110.23]:12897 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933271AbaD3Lsy (ORCPT ); Wed, 30 Apr 2014 07:48:54 -0400 Message-ID: <1398858529.24255.3.camel@hornet> Subject: Re: [PATCH 01/10] of: Keep track of populated platform devices From: Pawel Moll To: Grant Likely Cc: Rob Herring , "devicetree@vger.kernel.org" , Russell King , Samuel Ortiz , Arnd Bergmann , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Rob Herring , Lee Jones , "linux-arm-kernel@lists.infradead.org" Date: Wed, 30 Apr 2014 12:48:49 +0100 In-Reply-To: <20140429125657.65910C4089D@trevor.secretlab.ca> References: <1398707877-22596-1-git-send-email-pawel.moll@arm.com> <1398707877-22596-2-git-send-email-pawel.moll@arm.com> <20140429125657.65910C4089D@trevor.secretlab.ca> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-04-29 at 13:56 +0100, Grant Likely wrote: > > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > > > index 404d1da..0ae757a 100644 > > > --- a/drivers/of/platform.c > > > +++ b/drivers/of/platform.c > > > @@ -204,7 +204,8 @@ static struct platform_device *of_platform_device_create_pdata( > > > { > > > struct platform_device *dev; > > > > > > - if (!of_device_is_available(np)) > > > + if (!of_device_is_available(np) || > > > + of_node_check_flag(np, OF_POPULATED)) > > > > This and the amba case should be a test_and_set operation to avoid a > > race condition. > > Yes. It is an unlikely condition at the time that Pawel is handling, but > it should also work for later calls to of_platform_populate() which may > happen at runtime and in parallel. Sure thing, will fix. Thanks! Pawel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/