Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759350AbaD3PxM (ORCPT ); Wed, 30 Apr 2014 11:53:12 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:39610 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758895AbaD3PxK (ORCPT ); Wed, 30 Apr 2014 11:53:10 -0400 Date: Wed, 30 Apr 2014 08:53:08 -0700 From: Stephen Boyd To: Mike Turquette Cc: Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] clk: qcom: Various fixes for MSM8960's global clock controller Message-ID: <20140430155308.GE20486@codeaurora.org> References: <1396629176-7413-1-git-send-email-galak@codeaurora.org> <20140429065114.7224.13620@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140429065114.7224.13620@quantum> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/28, Mike Turquette wrote: > Quoting Kumar Gala (2014-04-04 09:32:56) > > diff --git a/include/dt-bindings/clock/qcom,gcc-msm8960.h b/include/dt-bindings/clock/qcom,gcc-msm8960.h > > index 03bbf49..f9f5471 100644 > > --- a/include/dt-bindings/clock/qcom,gcc-msm8960.h > > +++ b/include/dt-bindings/clock/qcom,gcc-msm8960.h > > @@ -51,7 +51,7 @@ > > #define QDSS_TSCTR_CLK 34 > > #define SFAB_ADM0_M0_A_CLK 35 > > #define SFAB_ADM0_M1_A_CLK 36 > > -#define SFAB_ADM0_M2_A_CLK 37 > > +#define SFAB_ADM0_M2_H_CLK 37 > > Technically these changes break backwards compatibility, but I guess > that field updates to newer kernel images for this SoC are not a > concern? I thought only the number was the ABI. The #defines are just here to make it easier to speak about the same numbers in the driver and the DT. Technically we could have made two #defines for 37 but since nobody is using it so far, it seems easier to just rename it. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/