Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759458AbaD3TYS (ORCPT ); Wed, 30 Apr 2014 15:24:18 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:60103 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758944AbaD3TYR (ORCPT ); Wed, 30 Apr 2014 15:24:17 -0400 Message-ID: <53614DDC.30901@gmail.com> Date: Wed, 30 Apr 2014 14:24:12 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Mike Turquette , Dinh Nguyen , ZY - pavel CC: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: socfpga: fix clock driver for 3.15 References: <1397481336-5592-1-git-send-email-dinguyen@altera.com> <20140424152133.GA23032@amd.pavel.ucw.cz> <1398379669.14881.2.camel@linux-builds1> <20140430191902.5718.91761@quantum> In-Reply-To: <20140430191902.5718.91761@quantum> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/30/14 2:19 PM, Mike Turquette wrote: > Quoting Dinh Nguyen (2014-04-24 15:47:49) >> Hi Mike, >> >> On Thu, 2014-04-24 at 17:21 +0200, ZY - pavel wrote: >>> Hi! >>> >>>> commit [1771b10d6 clk: respect the clock dependencies in of_clk_init] >>>> exposed a flaw in the socfpga clock driver and prevents the platform >>>> from booting on 3.15-rc1. >>>> >>>> Because the "altr,clk-mgr" is not really a clock, it should not be using >>>> CLK_OF_DECLARE, instead we should be mapping the clk-mgr's base address >>>> one of the functional clock init function. Use the socfpga_pll_init function >>>> to map the clk_mgr_base_addr as this clock should always be initialized first. >>>> >>>> Signed-off-by: Dinh Nguyen >>> Works for me, thanks! >>> Pavel >>> >>> Tested-by: Pavel Machek >>> >> I'm hoping you can queued this up for one of the 3.15-rc. > I took this in a few days ago but forgot to reply. It's in clk-fixes for > the next batch. Thanks! Dinh > > Regards, > Mike > >> Thanks, >> Dinh >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/