Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759823AbaD3XFE (ORCPT ); Wed, 30 Apr 2014 19:05:04 -0400 Received: from mail-vc0-f177.google.com ([209.85.220.177]:37236 "EHLO mail-vc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759803AbaD3XE7 (ORCPT ); Wed, 30 Apr 2014 19:04:59 -0400 MIME-Version: 1.0 In-Reply-To: <20140430221238.GV18016@ZenIV.linux.org.uk> References: <20140430160345.GP18016@ZenIV.linux.org.uk> <20140430183650.GQ18016@ZenIV.linux.org.uk> <20140430190227.GR18016@ZenIV.linux.org.uk> <20140430195918.GS18016@ZenIV.linux.org.uk> <20140430203823.GT18016@ZenIV.linux.org.uk> <20140430211206.GU18016@ZenIV.linux.org.uk> <20140430221238.GV18016@ZenIV.linux.org.uk> Date: Wed, 30 Apr 2014 16:04:58 -0700 X-Google-Sender-Auth: HZaNyAGy71zO77iX39dsk9JT_1s Message-ID: Subject: Re: dcache shrink list corruption? From: Linus Torvalds To: Al Viro Cc: Miklos Szeredi , Dave Chinner , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 30, 2014 at 3:12 PM, Al Viro wrote: > > I've just pushed the whole thing to vfs.git#for-linus; > review and testing would be very welcome. I have no half-way relevant test-case for this, so I'm hoping people who have good VFS stress-tests (preferably under memory pressure so that we get that whole shrinking path) will test. But it looks fine. That said, I do hate that RCU read-lock around the final spin-unlock. Let me go talk to the paravirt people. Maybe they don't need this, and I don't know exactly *how* they use that lock pointer after the unlock in the "kick waiters" part. Maybe it's all good. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/