Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbaEADcM (ORCPT ); Wed, 30 Apr 2014 23:32:12 -0400 Received: from mail-ig0-f169.google.com ([209.85.213.169]:54160 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbaEADcI (ORCPT ); Wed, 30 Apr 2014 23:32:08 -0400 MIME-Version: 1.0 In-Reply-To: References: <1398562711-6313-1-git-send-email-chase.southwood@gmail.com> <1398760700-19397-1-git-send-email-chase.southwood@gmail.com> Date: Wed, 30 Apr 2014 22:32:07 -0500 Message-ID: Subject: Re: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters From: Chase Southwood To: Hartley Sweeten Cc: "gregkh@linuxfoundation.org" , "abbotti@mev.co.uk" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hartley, Yes, you raise very good points. In any case, I have added cover letters to my submitting checklist so hopefully everything will be a lot easier for everyone next go round. Thanks, Chase On Wed, Apr 30, 2014 at 11:58 AM, Hartley Sweeten wrote: > On Wednesday, April 30, 2014 12:52 AM, Chase Southwood wrote: >> Thanks so much, I greatly appreciate the review. I'll fix the >> changelog for patch 4 and send once more (as I assume that's easier >> for Greg). Also, I should know better about the cover letter as >> well...I was once told not to send them for strictly cleanup patchsets >> (as Greg can't do anything with them and cleanups should be obvious) >> but I've gotten in the habit of not doing a cover letter for any >> patchsets. I will send cover letters (and be more careful about my >> other mistakes) in the future. > > Chase, > > Good job on the cleanup you have done so far. > > The cover letter does not get committed as part of the patch set. But > when you are submitting a series it give a convenient place to add > the sign off tag for a series. Also, if you would have done a cover letter > for this series you would have probably spotted the subject line issues > in patches 5 and 6. > > Keep up the good work! > > Hartley > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/