Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757690AbaFAN7n (ORCPT ); Sun, 1 Jun 2014 09:59:43 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:45972 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757453AbaFAN7l (ORCPT ); Sun, 1 Jun 2014 09:59:41 -0400 From: Yann Droneaud To: Al Viro Cc: Yann Droneaud , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , trivial@kernel.org Subject: [PATCHv7 4/6] file: use get_unused_fd_flags(0) instead of get_unused_fd() Date: Sun, 1 Jun 2014 15:58:45 +0200 Message-Id: <65a2618acc6a6f55e4d9aedd89292b0378dac37b.1401630396.git.ydroneaud@opteya.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Macro get_unused_fd() is used to allocate a file descriptor with default flags. Those default flags (0) can be "unsafe": O_CLOEXEC must be made the default to not leak file descriptor across exec(). In a further patch, get_unused_fd() will be removed so that new code start using get_unused_fd_flags() (or anon_inode_getfd()) with correct flags. This patch replaces calls to get_unused_fd() with equivalent call to get_unused_fd_flags(0). Link: http://lkml.kernel.org/r/cover.1401630396.git.ydroneaud@opteya.com Cc: Al Viro Cc: Andrew Morton Signed-off-by: Yann Droneaud --- fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/file.c b/fs/file.c index 66923fe3176e..4186f81cd9f1 100644 --- a/fs/file.c +++ b/fs/file.c @@ -868,7 +868,7 @@ SYSCALL_DEFINE1(dup, unsigned int, fildes) struct file *file = fget_raw(fildes); if (file) { - ret = get_unused_fd(); + ret = get_unused_fd_flags(0); if (ret >= 0) fd_install(ret, file); else -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/