From: Matthew Garrett <matthew.garrett@nebula.com>
To: "andreas.noever@gmail.com" <andreas.noever@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "greg@kroah.com" <greg@kroah.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH v4 00/15] Thunderbolt driver for Apple MacBooks
Thread-Topic: [PATCH v4 00/15] Thunderbolt driver for Apple MacBooks
Thread-Index: AQHPfNyYVDcE17ZFH0KR3hCN8Vnny5tcCgKpgABjiYA=
Date: Sun, 1 Jun 2014 16:07:49 +0000
Message-ID: <1401638869.7663.21.camel@x230>
References: <1401546480-2071-1-git-send-email-andreas.noever@gmail.com>
	 <1401580281.7663.14.camel@x230>
	 <CAMxnaaURVhZ_SiJW7Qy1bsye1bcPE=J=vjL5MgTN5znP15WnXw@mail.gmail.com>
In-Reply-To: <CAMxnaaURVhZ_SiJW7Qy1bsye1bcPE=J=vjL5MgTN5znP15WnXw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-ID: <C5BC7AFE9E9B4A4C9D83A32D09E75720@namprd05.prod.outlook.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit

On Sun, 2014-06-01 at 12:11 +0200, Andreas Noever wrote:
> On Sun, Jun 1, 2014 at 1:51 AM, Matthew Garrett
> <matthew.garrett@nebula.com> wrote:
> > This seems to be working well on my MBP. It appears to broadly work on
> > my Mac Pro, which has Thunderbolt 2 hardware - I added the PCI ID, and
> > loading the thunderbolt driver after the device is plugged in works, but
> > it won't recognise hotplug events. I don't appear to get any interrupts
> > from the Thunderbolt controller. Any idea what might be happening there?
> So the communication with the controller works (dmesg dumps a list of
> ports etc.)? Do you get plug events ("resetting error on port ...")?
> You could try to play around with tb_plug_events_active, if you want
> to experiment. I can also take another look at what OS X does once I
> get back to my workstation (when I worked on this part falcon ridge
> was not jet released, so maybe they do things differently now).

Yeah, that was it. I'll mail the patch separately.


> > As far as the quirks go - perhaps something like this would be
> > reasonable, rather than maintaining a list of machines?
> I have obtained ACPI dumps from a late 2013 MBP and from a MacPro
> (both are falcon ridge devices) and these contain a few firmware
> changes. For example SXIO, SXIL and SXLV are gone so the shutdown
> quirk will fail. With some luck that means that the shutdown quirk is
> no longer required for falcon ridge hardware.

Yeah, it seems I don't need the suspend quirk - the NHI is still there
without it. I still think we should make the quirk general rather than
tying it to the machines, the worst case is that it'll just do nothing.

-- 
Matthew Garrett <matthew.garrett@nebula.com>
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?