Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbaFBDwM (ORCPT ); Sun, 1 Jun 2014 23:52:12 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:43949 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbaFBDwK (ORCPT ); Sun, 1 Jun 2014 23:52:10 -0400 MIME-Version: 1.0 In-Reply-To: References: <1401424853-21683-1-git-send-email-chase.southwood@gmail.com> <1401425032-22721-1-git-send-email-chase.southwood@gmail.com> Date: Sun, 1 Jun 2014 22:52:09 -0500 Message-ID: Subject: Re: [PATCH 6/6] staging: comedi: addi_apci_1564: cleanup v_ADDI_Interrupt() From: Chase Southwood To: Hartley Sweeten Cc: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "abbotti@mev.co.uk" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 30, 2014 at 12:26 PM, Hartley Sweeten wrote: > On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote: >> Move the function apci1564_interrupt() from hwdrv_apci1564.c to >> addi_apci_1564.c. On moving, for now just strip out all of the >> code for interrupts that the driver does not yet support at this >> time. >> >> Rename the variable ui_InterruptStatus_1564 to ctrl, and change the return >> from IRQ_RETVAL(1) to IRQ_HANDLED. >> >> We also check the device is asserting the shared interrupt line and check >> that interrupts have been enabled. >> >> Signed-off-by: Chase Southwood >> Cc: Ian Abbott >> Cc: H Hartley Sweeten >> --- Hartley, Excellent...I will draft up a new version of this set based on all of your comments, but I will hold off on sending until I see if Ian has anything further to offer. Things are certainly looking better already though. Thanks, Chase -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/