Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649AbaFBM4y (ORCPT ); Mon, 2 Jun 2014 08:56:54 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:65480 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754338AbaFBM4v (ORCPT ); Mon, 2 Jun 2014 08:56:51 -0400 Message-ID: <538C7484.9070801@gmail.com> Date: Mon, 02 Jun 2014 14:56:36 +0200 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz , Kukjin Kim CC: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Sachin Kamat , Viresh Kumar , Tomasz Figa , Daniel Lezcano , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Kyungmin Park , linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/7] ARM: EXYNOS: add support for firmware-assisted c15resume References: <1401712543-14281-1-git-send-email-b.zolnierkie@samsung.com> <1401712543-14281-3-git-send-email-b.zolnierkie@samsung.com> In-Reply-To: <1401712543-14281-3-git-send-email-b.zolnierkie@samsung.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02.06.2014 14:35, Bartlomiej Zolnierkiewicz wrote: > From: Tomasz Figa > > This change is a preparation for adding secure firmware support to > EXYNOS cpuidle driver. > > This patch shouldn't cause any functionality changes. > > Signed-off-by: Tomasz Figa > [bzolnier: splitted out from bigger patch] > Acked-by: Kyungmin Park > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/include/asm/firmware.h | 4 ++++ > arch/arm/mach-exynos/firmware.c | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm/include/asm/firmware.h b/arch/arm/include/asm/firmware.h > index c72ec47..70883c7 100644 > --- a/arch/arm/include/asm/firmware.h > +++ b/arch/arm/include/asm/firmware.h > @@ -41,6 +41,10 @@ struct firmware_ops { > * Initializes L2 cache > */ > int (*l2x0_init)(void); > + /* > + * Restores coprocessor 15 registers > + */ > + int (*c15resume)(u32 *regs); Well, this was just a kind of internal hack, so I'm not sure this is suitable as a generic firmware operation in mainline. I'd rather implement this as a part of a wider suspend and resume firmware operations, where suspend would save values of cp15 registers and resume would restore them. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/