Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138AbaFBNI2 (ORCPT ); Mon, 2 Jun 2014 09:08:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25817 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176AbaFBNI0 (ORCPT ); Mon, 2 Jun 2014 09:08:26 -0400 Date: Mon, 2 Jun 2014 15:06:32 +0200 From: Stanislaw Gruszka To: Sergei Shtylyov , Michael Braun Cc: Ivo van Doorn , Helmut Schaa , netdev@vger.kernel.org, users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org, "John W. Linville" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] rt2800usb:fix efuse detection Message-ID: <20140602130631.GA1632@redhat.com> References: <20140601174736.7980.18330.stgit@charlie.fem.tu-ilmenau.de> <20140601175247.7980.2461.stgit@charlie.fem.tu-ilmenau.de> <538B79A3.1080104@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <538B79A3.1080104@cogentembedded.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 01, 2014 at 11:06:11PM +0400, Sergei Shtylyov wrote: > >+ rt2x00usb_vendor_request(rt2x00dev, USB_DEVICE_MODE, > >+ USB_VENDOR_REQUEST_IN, 0, 0x11, &fwMode, > >+ sizeof(fwMode), REGISTER_TIMEOUT_FIRMWARE); > >+ > >+ if ((fwMode & 0x00000003) == 2) > > Operating directly on '__le32'? That doesn't look right. rt2x00usb_register_read() helper can be used to do conversion. I also dislike using 0x11 number instead of register name and prefer kernel like variable names (i.e. fw_mode instead of fwMode). Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/