Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853AbaFBNRQ (ORCPT ); Mon, 2 Jun 2014 09:17:16 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:43185 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753267AbaFBNRN (ORCPT ); Mon, 2 Jun 2014 09:17:13 -0400 Date: Mon, 2 Jun 2014 14:17:04 +0100 From: Mark Rutland To: Michal Simek Cc: Harini Katakam , "wim@iguana.be" , "grant.likely@linaro.org" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "rob@landley.net" , "michals@xilinx.com" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver Message-ID: <20140602131704.GE13573@leverpostej> References: <1401185895-3677-1-git-send-email-harinik@xilinx.com> <20140529092106.GC24233@leverpostej> <53870129.5010505@monstr.eu> <20140529131940.GG24233@leverpostej> <538C18CC.6040105@monstr.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <538C18CC.6040105@monstr.eu> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 02, 2014 at 07:25:16AM +0100, Michal Simek wrote: > On 05/29/2014 03:19 PM, Mark Rutland wrote: > > On Thu, May 29, 2014 at 10:43:05AM +0100, Michal Simek wrote: > >> Hi Mark, > >> > >>>> +static struct of_device_id cdns_wdt_of_match[] = { > >>>> + { .compatible = "xlnx,zynq-wdt-r1p2", }, > >>>> + { .compatible = "cdns,wdt-r1p2", }, > >>> > >>> If these can currently be handled identically, why not just have > >>> "cdns,wdt-r1p2" in the driver and in your dts have: > >>> > >>> compatible = "xlnx,zynq-wdt-r1p2", "cdns,wdt-r1p2"; > >>> > >>> If we need to distinguish the two for some reason later we can always > >>> add the "xlnx,zynq-wdt-r1p2" string to the driver. > >> > >> I would prefer to have 2 compatible strings just because > >> of that we don't know what is different compare to origin cadence > >> version. We have done the same for spi-cadence.c that's why > >> it shouldn't be any problem to keep it as is. > >> Having zynq compatible property here and using it give us option > >> that if another SoC vendor come with new configuration or clean > >> cadence one we can simple handle it without changing compatible > >> property for us. > > > > Sure, we can have two documented strings. But as I mention for the > > moment the driver only needs to support the one string so long as a > > given dts has both. Then we can later distinguish the zynq variant (or > > any other) as necessary. > > ok then. Let's use just "xlnx,zynq-wdt-r1p2" compatible string here > and remove "cdns,wdt-r1p2" That if anything seems backwards -- the driver should jsut take the most general string for now: "cdns,wdt-r1p2", while the dtb will have both: compatible = "xlnx,zynq-wdt-r1p2", "cdns,wdt-r1p2"; The driver can later disintguish "xlnx,zynq-wdt-r1p2" specially if necessary. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/