Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932475AbaFCIVm (ORCPT ); Tue, 3 Jun 2014 04:21:42 -0400 Received: from mx2.parallels.com ([199.115.105.18]:58185 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932211AbaFCIVg (ORCPT ); Tue, 3 Jun 2014 04:21:36 -0400 Date: Tue, 3 Jun 2014 12:21:26 +0400 From: Vladimir Davydov To: Joonsoo Kim CC: Joonsoo Kim , Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , LKML , Linux Memory Management List Subject: Re: [PATCH -mm 8/8] slab: reap dead memcg caches aggressively Message-ID: <20140603082124.GB6013@esperanza> References: <23a736c90a81e13a2252d35d9fc3dc04a9ed7d7c.1401457502.git.vdavydov@parallels.com> <20140602044154.GB17964@js1304-P5Q-DELUXE> <20140602121034.GB1039@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [109.195.248.178] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 02, 2014 at 11:01:55PM +0900, Joonsoo Kim wrote: > 2014-06-02 21:10 GMT+09:00 Vladimir Davydov : > > On Mon, Jun 02, 2014 at 01:41:55PM +0900, Joonsoo Kim wrote: > >> According to my code reading, slabs_to_free() doesn't return number of > >> free slabs. This bug is introduced by 0fa8103b. I think that it is > >> better to fix it before applyting this patch. Otherwise, use n->free_objects > >> instead of slabs_tofree() to achieve your purpose correctly. > > > > Hmm, I don't think slab_tofree() computes the number of free slabs > > wrong. If we have N free objects, there may be > > DIV_ROUND_UP(N,objs_per_slab) empty slabs at max, and that's exactly > > what slab_tofree() does, no? > [...] > BTW, we don't need DIV_ROUND_UP. I think that just N / objs_per_slab is > sufficient to get number of empty slabs at max. Am I missing too? Yeah, you're right - DIV_ROUND_UP is obviously redundant, DIV would be enough. Not a bug though. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/