Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbaFCKIU (ORCPT ); Tue, 3 Jun 2014 06:08:20 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:52771 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbaFCKIR (ORCPT ); Tue, 3 Jun 2014 06:08:17 -0400 MIME-Version: 1.0 In-Reply-To: <538D9DBD.2030605@linux.vnet.ibm.com> References: <20140526205337.1100.55275.stgit@srivatsabhat.in.ibm.com> <538D9631.9090500@linux.vnet.ibm.com> <538D9DBD.2030605@linux.vnet.ibm.com> Date: Tue, 3 Jun 2014 15:38:17 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: governor: Be friendly towards latency-sensitive bursty workloads From: Viresh Kumar To: "Srivatsa S. Bhat" Cc: "Rafael J. Wysocki" , Vaidyanathan Srinivasan , "ego@linux.vnet.ibm.com" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3 June 2014 15:34, Srivatsa S. Bhat wrote: > Well, the method I used keeps the organization such that the code following > the comment does precisely what the comment says (i.e, get the sampling_rate, > fetch the multiplier, and then multiply). So I feel it makes it easier to > understand. It looked like the comment is there only for this special statement: >>> + sampling_rate *= od_dbs_info->rate_mult; And so suggested that :) Anyway move this up as it doesn't belong to comment for sure. >> + od_dbs_info = dbs_data->cdata->get_cpu_dbs_info_s(cpu); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/