Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932739AbaFCOAZ (ORCPT ); Tue, 3 Jun 2014 10:00:25 -0400 Received: from mail-qa0-f50.google.com ([209.85.216.50]:65129 "EHLO mail-qa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932153AbaFCOAX (ORCPT ); Tue, 3 Jun 2014 10:00:23 -0400 MIME-Version: 1.0 In-Reply-To: <1401803636.2274.6.camel@dmt> References: <1222713404-1097-1-git-send-email-ajax@redhat.com> <1393343227-13092-1-git-send-email-ajax@redhat.com> <1401803636.2274.6.camel@dmt> Date: Tue, 3 Jun 2014 10:00:22 -0400 Message-ID: Subject: Re: [PATCH] i8042: Don't print an error message just because there's no chip From: Benjamin Tissoires To: Adam Jackson Cc: Josh Boyer , linux-input , "Linux-Kernel@Vger. Kernel. Org" , Peter Jones , Dmitry Torokhov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 3, 2014 at 9:53 AM, Adam Jackson wrote: > On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote: >> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson wrote: >> > From: Peter Jones >> > >> > Some systems, such as EFI-based Apple systems, won't necessarily have an >> > i8042 to initialize. We shouldn't be printing an error message in this >> > case, since not detecting the chip is the correct behavior. >> > >> > v2: Downgrade to pr_notice instead of pr_err. >> > >> > Signed-off-by: Adam Jackson >> >> Reviewed-by: Josh Boyer > > Ping? This patch or something like it has been pending since 2008 [1], > would be nice to see it merged before it's old enough to start first > grade. > > [1] - https://lkml.org/lkml/2008/9/29/248 > Hey Ajax, regarding the input stuff, adding the maintainers always help. So adding Dmitry in CC. BTW, the patch looks good enough: Reviewed-by: Benjamin Tissoires Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/