Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932516AbaFCOs4 (ORCPT ); Tue, 3 Jun 2014 10:48:56 -0400 Received: from qmta05.emeryville.ca.mail.comcast.net ([76.96.30.48]:49757 "EHLO qmta05.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754511AbaFCOsy (ORCPT ); Tue, 3 Jun 2014 10:48:54 -0400 Date: Tue, 3 Jun 2014 09:48:51 -0500 (CDT) From: Christoph Lameter To: Vladimir Davydov cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -mm 5/8] slab: remove kmem_cache_shrink retval In-Reply-To: <20140603090623.GC6013@esperanza> Message-ID: References: <20140531102740.GB25076@esperanza> <20140603090623.GC6013@esperanza> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Jun 2014, Vladimir Davydov wrote: > Still, I really want to evict all empty slabs from cache on memcg > offline for sure. Handling failures there means introducing a worker > that will retry shrinking, but that seems to me as an unnecessary > complication, because there's nothing that can prevent us from shrinking > empty slabs from the cache, even if we merge slab defragmentation, isn't > it? > > May be, it's worth introducing a special function, say kmem_cache_zap(), > that will only evict empty slabs from the cache, plus disable empty > slabs caching? This function would be called only from memcg offline for > dead memcg caches. I am fine with the lower impact version that you came up with later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/