Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964834AbaFCUCn (ORCPT ); Tue, 3 Jun 2014 16:02:43 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:55714 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933084AbaFCUCl (ORCPT ); Tue, 3 Jun 2014 16:02:41 -0400 Message-ID: <1401825759.3645.233.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH 3/5] irq_work: Implement remote queueing From: Eric Dumazet To: Peter Zijlstra Cc: Frederic Weisbecker , Ingo Molnar , LKML , Andrew Morton , Kevin Hilman , "Paul E. McKenney" , Thomas Gleixner , Viresh Kumar Date: Tue, 03 Jun 2014 13:02:39 -0700 In-Reply-To: <20140603163745.GC30445@twins.programming.kicks-ass.net> References: <1401806420-31018-1-git-send-email-fweisbec@gmail.com> <1401806420-31018-4-git-send-email-fweisbec@gmail.com> <1401812947.3645.231.camel@edumazet-glaptop2.roam.corp.google.com> <20140603163745.GC30445@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-06-03 at 18:37 +0200, Peter Zijlstra wrote: > On Tue, Jun 03, 2014 at 09:29:07AM -0700, Eric Dumazet wrote: > > > +bool irq_work_queue_on(struct irq_work *work, int cpu) > > > +{ > > > + /* All work should have been flushed before going offline */ > > > + WARN_ON_ONCE(cpu_is_offline(cpu)); > > > + > > > + /* Arch remote IPI send/receive backend aren't NMI safe */ > > > + WARN_ON_ONCE(in_nmi()); > > > + > > > + /* Only queue if not already pending */ > > > + if (!irq_work_claim(work)) > > > + return false; > > > + > > > + if (llist_add(&work->llnode, &per_cpu(raised_list, cpu))) > > > + native_send_call_func_single_ipi(cpu); > > > + > > > + return true; > > > +} > > > +EXPORT_SYMBOL_GPL(irq_work_queue_on); > > > + > > > > I am curious, this should only compile on x86, right ? > > Oh, you tease, you forgot to say why you think this. > > Are you referring to the in_nmi() usage? that's from > include/linux/hardirq.h, hardly x86 specific. No, my eyes were attracted by native_send_call_func_single_ipi() -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/