Date: Tue, 3 Jun 2014 15:08:50 -0700
From: josh@joshtriplett.org
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Dave Chinner <david@fromorbit.com>,
        Joe Perches <joe@perches.com>, paulmck@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com,
        dipankar@in.ibm.com, akpm@linux-foundation.org,
        mathieu.desnoyers@efficios.com, niv@us.ibm.com, tglx@linutronix.de,
        peterz@infradead.org, dhowells@redhat.com, edumazet@google.com,
        dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
        sbw@mit.edu
Subject: Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag
Message-ID: <20140603220850.GA20736@cloud>
References: <20140602190951.GA13648@cloud>
 <1401736666.7323.25.camel@joe-AO725>
 <20140602231949.GV14410@dastard>
 <20140602235915.GB14801@cloud>
 <20140603011125.GW14410@dastard>
 <20140602213045.26219ddb@gandalf.local.home>
 <20140603071654.GC14410@dastard>
 <20140603134347.6e39f946@gandalf.local.home>
 <20140603205253.GC25483@thunk.org>
 <20140603174631.2de89352@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140603174631.2de89352@gandalf.local.home>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Jun 03, 2014 at 05:46:31PM -0400, Steven Rostedt wrote:
> On Tue, 3 Jun 2014 16:52:53 -0400
> Theodore Ts'o <tytso@mit.edu> wrote:
> 
> 
> > The important thing to note here is that we do not have consensus
> > across all subsystems what Reviewed-by: means, and I think that's OK.
> > The Reviewed-by: is mostly of interest to the maintainer before the
> > patch is submitted to mainline.  The value of keeping it in the git
> > commit logs after the fact seems to be a bit variable, although if
> > there are companies blindly using it as a performance metric and this
> > is driving down the quality of reviews, perhaps one could even argue
> > that including these tags in the git commit logs is actually adding
> > negative value.  But I don't really care about that issue, because
> > like most maintainers, I know the reviewers by reputation, and whether
> > someone actually says "you can add my Reviewed-by" is actually not so
> > important as their comments on the patch, one way or another.
> 
> I prefer the Reviewed-by tags in the git commit. If something is
> screwed up in a commit, I can blame the reviewers just as much as I can
> blame the author :-)

I like it there for the same reason: if there turns out to be an issue
in a commit I reviewed, I'd like to get CCed on the resulting discussion
and fix, so that I can take that into account in future reviews.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/