Date: Tue, 3 Jun 2014 16:23:17 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Francesco Ruggeri <fruggeri@aristanetworks.com>
Cc: linux-kernel@vger.kernel.org, hare@suse.de, linux@roeck-us.net,
        fruggeri@arista.com
Subject: Re: pci: kernel crash in bus_find_device
Message-ID: <20140603232317.GB15247@kroah.com>
References: <20140603225502.F1C5122C07D5@bs320.sjc.aristanetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140603225502.F1C5122C07D5@bs320.sjc.aristanetworks.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Jun 03, 2014 at 03:55:02PM -0700, Francesco Ruggeri wrote:
> @@ -719,6 +719,11 @@ struct pci_dev *pci_get_device(unsigned 
>  struct pci_dev *pci_get_subsys(unsigned int vendor, unsigned int device,
>  				unsigned int ss_vendor, unsigned int ss_device,
>  				struct pci_dev *from);
> +struct pci_dev *pci_get_device_noref(unsigned int vendor, unsigned int device,
> +				     struct pci_dev *from);
> +struct pci_dev *pci_get_subsys_noref(unsigned int vendor, unsigned int device,
> +				     unsigned int ss_vendor, unsigned int ss_device,
> +				     struct pci_dev *from);

To follow up, what drivers are you thinking need to make these calls?
Perhaps they shouldn't be doing something like this?

And, to answer my previous question, the reason PCI is different is that
drivers want to walk the list of devices to find "stupid" things like
this out, USB doesn't do dumb stuff like that :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/