Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbaFDJqn (ORCPT ); Wed, 4 Jun 2014 05:46:43 -0400 Received: from mx0.aculab.com ([213.249.233.131]:53639 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751746AbaFDJql convert rfc822-to-8bit (ORCPT ); Wed, 4 Jun 2014 05:46:41 -0400 From: David Laight To: "'Julia Lawall'" , Geert Uytterhoeven CC: linux-rdma , "kernel-janitors@vger.kernel.org" , Linux Fbdev development list , Linux-sh list , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" , linux-wireless , "netdev@vger.kernel.org" , driverdevel , "iss_storagedev@hp.com" , scsi , linux-s390 , "adi-buildroot-devel@lists.sourceforge.net" Subject: RE: [PATCH 0/10] use safer test on the result of find_first_zero_bit Thread-Topic: [PATCH 0/10] use safer test on the result of find_first_zero_bit Thread-Index: AQHPf9jD3P2Wp/I7I0O0KpvEWFb8KZtgszAA Date: Wed, 4 Jun 2014 09:46:17 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1725705F@AcuExch.aculab.com> References: <1401872880-23685-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julia Lawall > On Wed, 4 Jun 2014, Geert Uytterhoeven wrote: > > > Hi Julia, > > > > On Wed, Jun 4, 2014 at 11:07 AM, Julia Lawall wrote: > > > Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may > > > return a larger number than the maximum position argument if that position > > > is not a multiple of BITS_PER_LONG. > > > > Shouldn't this be fixed in find_first_zero_bit() instead? > > OK, I could do that as well. Most of the callers currently test with >=. > Should they be left as is, or changed to use ==? Do we want to add an extra test to find_first_zero_bit() and effectively slow down all the calls - especially those where the length is a multiple of 8 (probably the most common). Maybe the documented return code should be changed to allow for the existing behaviour. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/