Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834AbaFDMWt (ORCPT ); Wed, 4 Jun 2014 08:22:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59934 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbaFDMWs (ORCPT ); Wed, 4 Jun 2014 08:22:48 -0400 Date: Wed, 4 Jun 2014 14:22:38 +0200 From: Jiri Olsa To: Masami Hiramatsu Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim , Ingo Molnar , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH -tip ] [BUGFIX] perf/probe: Fix perf probe to find correct variable DIE Message-ID: <20140604122238.GA6902@krava.brq.redhat.com> References: <20140529105232.28251.30447.stgit@ltc230.yrl.intra.hitachi.co.jp> <20140529121930.30879.87092.stgit@ltc230.yrl.intra.hitachi.co.jp> <53872A72.6040007@hitachi.com> <20140603203823.GG3696@kernel.org> <538ED7DE.5070508@hitachi.com> <20140604113124.GC5555@krava.brq.redhat.com> <538F0EED.7030504@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <538F0EED.7030504@hitachi.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 04, 2014 at 09:19:57PM +0900, Masami Hiramatsu wrote: > (2014/06/04 20:31), Jiri Olsa wrote: > > On Wed, Jun 04, 2014 at 05:25:02PM +0900, Masami Hiramatsu wrote: > >> (2014/06/04 5:38), Arnaldo Carvalho de Melo wrote: > >>> Now trying to reference a bogus member name: > >>> > >>> [root@zoo ~]# perf probe 'vfs_getname=getname_flags:65 pathname=result->BOGUS:string' > >>> result(type:filename) has no member BOGUS. > >>> Failed to find 'result' in this function. > >>> Error: Failed to add events. (-22) > >>> [root@zoo ~]# > >>> > >>> No segfault, albeit it produces a bogus error message, as it clearly > >>> _finds_ the 'result' variable, its just that it is of a struct type that > >>> _has_ no such 'BOGUS' _member_. > >> > >> Right, I'll fix that. > > > > should I wait for new patchset, or should I take those 2? > > No, those 2 patches are urgently required, because one fixes SEGV critical > error, and the other fixes a wrong behavior (catch up to the latest > dwarf), which is also degradation. ok, I'll queue both of them to perf/urgent thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/