Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbaFDNCX (ORCPT ); Wed, 4 Jun 2014 09:02:23 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:34564 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753051AbaFDNCV (ORCPT ); Wed, 4 Jun 2014 09:02:21 -0400 Message-ID: <538F18B6.7070102@ti.com> Date: Wed, 4 Jun 2014 08:01:42 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Grazvydas Ignotas CC: , Tony Lindgren , "linux-kernel@vger.kernel.org" , Felipe Balbi , "linux-omap@vger.kernel.org" , , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH V2 2/2] power: twl4030_charger: attempt to power off in case of critical events References: <1401313610-14252-1-git-send-email-nm@ti.com> <1401313610-14252-3-git-send-email-nm@ti.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2014 05:04 AM, Grazvydas Ignotas wrote: > On Thu, May 29, 2014 at 12:46 AM, Nishanth Menon wrote: >> Attempt to power off in case of critical events such as battery removal, >> over voltage events. >> >> There is no guarentee that we'd be in a safe scenario here, but the very >> least we can try to do is to power off the device to prevent damage to >> the system instead of just printing a message and hoping for the best. > > At least "battery temperature out of range" does seem to happen quite > often while charging on hot summer day. I'd prefer my pandora to not > shutdown in such case, it could just stop charging instead. Yeah, We could call twl4030_charger_enable_ac(false); twl4030_charger_enable_usb(bci, false); But then, is that sufficient? >From the TRM: 7.5.8 Battery Temperature Out-of-Range Detection Battery temperature out-of-range detection detects whether the battery temperature is within a specific range. Detection is possible for two temperature ranges. When the battery temperature is not in the 2–50°C range or is in the 3–43°C range, the TBATOR1 and TBATOR2 status bits rise and an interrupt is generated. This MADC monitoring function can be enabled by writing to the TBATOR1EN (BCIMFEN2[3]) and TBATOR2EN (BCIMFEN2[1]) fields. Battery pack at high temperature is a risk, no? and it may not be just charger that might be causing such a condition. Is'nt it safer to shut the device down in such a case? -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/