Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753460AbaFDNbX (ORCPT ); Wed, 4 Jun 2014 09:31:23 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:40607 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029AbaFDNbV (ORCPT ); Wed, 4 Jun 2014 09:31:21 -0400 Date: Wed, 4 Jun 2014 15:28:33 +0200 From: Thierry Reding To: Sumit Semwal Cc: Greg Kroah-Hartman , Maarten Lankhorst , LKML Subject: Re: [PATCH] fence: Use smp_mb__before_atomic() Message-ID: <20140604132831.GC28484@ulmo> References: <1401287192-14701-1-git-send-email-thierry.reding@gmail.com> <20140528205145.GB10468@kroah.com> <20140530081504.GA16669@ulmo> <20140530160831.GA11182@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z4+8/lEcDcG5Ke9S" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --z4+8/lEcDcG5Ke9S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: > Hi Greg, >=20 >=20 > On 30 May 2014 21:38, Greg Kroah-Hartman wro= te: > > On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: > >> On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: > >> > On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: > >> > > From: Thierry Reding > >> > > > >> > > Commit febdbfe8a91c (arch: Prepare for smp_mb__{before,after}_atom= ic()) > >> > > deprecated the smp_mb__{before,after}_{atomic,clear}_{dec,inc,bit}= *() > >> > > functions in favour of the unified smp_mb__{before,after}_atomic(). > >> > > > >> > > Signed-off-by: Thierry Reding > >> > > --- > >> > > drivers/base/fence.c | 4 ++-- > >> > > >> > Where does this file come from? I've not seen it before, and it's n= ot > >> > in my tree. > >> > >> I think it came in through Sumit's tree and it's only in linux-next I > >> believe. > > > > Odd, linux-next is for merging things in Linus's next release. > > > > And as I have never seen this code that will end up being my > > responsibility to maintain, it seems strange that it will be merged in > > the next kernel development cycle. > > > > What broke down here with our review process that required something to > > be merged without at least a cc: to me? >=20 > This is a new file added by Maarten's patches [1], that got reviewed > on dri-devel and other mailing lists. Since it was quite closely > associated with dma-buf, I figured I should take it through the > dma-buf tree. >=20 > I am sorry I didn't notice that you weren't CC'ed on these patches - > Sincere apologies, since I should've noticed that during the patch > review process - I would take part of the blame here as well :( >=20 > I do realize now that atleast on my part, I should've asked you before > taking it through the dma-buf tree - I will make sure things like this > don't happen again through me. >=20 > May I request you to help us handle this - would it help if we add > Maarten as the maintainer for this file? Any other suggestions? Perhaps something like the following would help? diff --git a/MAINTAINERS b/MAINTAINERS index fb39c9c3f0c1..d582f54adec8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2867,7 +2867,9 @@ L: linux-media@vger.kernel.org L: dri-devel@lists.freedesktop.org L: linaro-mm-sig@lists.linaro.org F: drivers/base/dma-buf* +F: drivers/base/fence.c F: include/linux/dma-buf* +F: include/linux/fence.h F: Documentation/dma-buf-sharing.txt T: git git://git.linaro.org/people/sumitsemwal/linux-dma-buf.git @@ -2936,6 +2938,8 @@ T: git git://git.kernel.org/pub/scm/linux/kern= el/git/gregkh/driver-core.git S: Supported F: Documentation/kobject.txt F: drivers/base/ +X: drivers/base/dma-buf* +X: drivers/base/fence.c F: fs/sysfs/ F: fs/debugfs/ F: include/linux/kobj* That removes Greg from the list generated by get_maintainer.pl for anything that touches the DMA-BUF files. Thinking about it, perhaps moving DMA-BUF into its own subdirectory would be an option too, to make the separation more obvious. That is, if that's something that Greg wants. Thierry --z4+8/lEcDcG5Ke9S Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTjx7/AAoJEN0jrNd/PrOh90UP/2ghsAZWKKnSkd2ia6+yBMzu ny80NRNXzhAbLDxzhKAm5g6OpDLPsChKO9ljsG2FnnCHhBEhlJO7k9jUBHVDoLNq q3GQ3d3K5OeJv4tfFvLdiM/Xe0BNbJ8u5IFIOxkE5URS9Wjcd5a9Hflq5dvbZ/L6 N0ZY/xtgeB18pbPBSDC1pdAA0KVRwsMEb7wxHJnzp2p6rpb8eDp+IiPAP9CvJOUK FKQwDhRTQCo5uDDawwU+fST/lIWkrdWUDTJ63OAcUWhqrK7+96JIjXqP9P582sg/ MX18yk9meHG5J8rbsMMA0en2aU0v2NByf8XROWzInodX7RqNtezBL5Y5iX+w8ABY b3CzdeLcYvdUDdrhL32znReEgIj6NVqFnsbuTwrBdqPrl1/EkK+yM+AihKPV2Q6k jVozj7yiykKhIi6myQVLJhrhgsbWUTLKbxjBY7mAuXUdPHVvOvwlI136DnO64SmE kTIvpZ6uqPuTvbewLhRsbX+piBo5DYX0Kv4vd7ZRhjIjVz7h8zRckI5EJ14tyUtT SY38NPIllmQXGCEYzUgdMIFlC6eaL1BM47TMv66+wG9JfJQn9OxNaDkYGZ94CBOY mgFlscwpwMistwxtNWwJSSwmP3QmTFUlRByhIJiUjvYMPQx87wMUTR95N7/IxfWh fsHfY+SzxRbtWbCV1JtW =LqJV -----END PGP SIGNATURE----- --z4+8/lEcDcG5Ke9S-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/