Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753106AbaFDPUB (ORCPT ); Wed, 4 Jun 2014 11:20:01 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:33888 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752776AbaFDPT7 (ORCPT ); Wed, 4 Jun 2014 11:19:59 -0400 Message-ID: <538F391B.8070005@kernel.dk> Date: Wed, 04 Jun 2014 09:19:55 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Christoph Hellwig CC: Shaohua Li , linux-kernel@vger.kernel.org Subject: Re: [patch]blk-mq: blk_mq_tag_to_rq should handle flush request References: <20140604111133.GA7826@infradead.org> <538F2A11.4060800@kernel.dk> <20140604142012.GA20056@infradead.org> <538F331F.60101@kernel.dk> <20140604145803.GA7826@infradead.org> <538F34FB.7050003@kernel.dk> <20140604150508.GA21551@infradead.org> <538F365C.8050604@kernel.dk> <20140604151020.GA13586@infradead.org> <538F3733.6040207@kernel.dk> <20140604151643.GA6344@infradead.org> In-Reply-To: <20140604151643.GA6344@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-06-04 09:16, Christoph Hellwig wrote: > On Wed, Jun 04, 2014 at 09:11:47AM -0600, Jens Axboe wrote: >> On 2014-06-04 09:10, Christoph Hellwig wrote: >>> On Wed, Jun 04, 2014 at 09:08:12AM -0600, Jens Axboe wrote: >>>>> The performance regression is caused by "blk-mq: avoid code >>>>> duplication", but I don't really understand why yet. >>>> >>>> Gah, looks like this one dropped the tag idling. I bet that is why. >>> >>> Ah, thanks. It's indeed exactly the same sort of slow down I bisected >>> back then, this should have rung a bell instead of keeping me occupied >>> for hours.. >> >> Patch is committed :-) > > Oh well, I had just prepared the same one for you, but I want to at > least do basic sanity checking of my rebased tree with the fixes applied > now that I'm done bisecting. Please do. If there's anything else I need, let me know. It wasn't clear to me if the cdb patch was in blk-mq or scsi-mq. I'll flush my queue out this afternoon, so that -rc1 will hopefully have everything in a sane state. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/