MIME-Version: 1.0
In-Reply-To: <20140429151100.GC8754@linux.vnet.ibm.com>
References: <1398205166.6345.7.camel@buesod1.americas.hpqcorp.net>
	<1398722941.25549.16.camel@buesod1.americas.hpqcorp.net>
	<20140428231002.GO4430@linux.vnet.ibm.com>
	<1398732649.2970.89.camel@schen9-DESK>
	<20140429151100.GC8754@linux.vnet.ibm.com>
Date: Wed, 4 Jun 2014 13:57:34 -0400
Message-ID: <CAJUuVQ4j93AXCij22eCdYT4L-hrshvbuisJQe8KPkYh2vx3+Xg@mail.gmail.com>
Subject: Re: [PATCH v2] rwsem: Support optimistic spinning
From: Andev <debiandev@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: Tim Chen <tim.c.chen@linux.intel.com>, Davidlohr Bueso <davidlohr@hp.com>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrea Arcangeli <aarcange@redhat.com>, Alex Shi <alex.shi@linaro.org>,
        Andi Kleen <andi@firstfloor.org>,
        Michel Lespinasse <walken@google.com>, Rik van Riel <riel@redhat.com>,
        Peter Hurley <peter@hurleysoftware.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Aswin Chandramouleeswaran <aswin@hp.com>,
        "Norton, Scott J" <scott.norton@hp.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

Hi,

On Tue, Apr 29, 2014 at 11:11 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> On Mon, Apr 28, 2014 at 05:50:49PM -0700, Tim Chen wrote:
>> On Mon, 2014-04-28 at 16:10 -0700, Paul E. McKenney wrote:
>>
>> > > +#ifdef CONFIG_SMP
>> > > +static inline bool rwsem_can_spin_on_owner(struct rw_semaphore *sem)
>> > > +{
>> > > + int retval;
>> > > + struct task_struct *owner;
>> > > +
>> > > + rcu_read_lock();
>> > > + owner = ACCESS_ONCE(sem->owner);
>> >
>> > OK, I'll bite...
>> >
>> > Why ACCESS_ONCE() instead of rcu_dereference()?
>>
>> We're using it as a speculative check on the sem->owner to see
>> if the owner is running on the cpu.  The rcu_read_lock
>> is used for ensuring that the owner->on_cpu memory is
>> still valid.
>
> OK, so if we read complete garbage, all that happens is that we
> lose a bit of performance?  If so, I am OK with it as long as there
> is a comment (which Davidlohr suggested later in this thread).
>
>                                                         Thanx, Paul
>

The latest code seems to be missing this comment. Could you please add this?

-- 
Pratapa Rudra
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/