Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 16 Nov 2002 13:42:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 16 Nov 2002 13:42:52 -0500 Received: from natsmtp00.webmailer.de ([192.67.198.74]:58586 "EHLO post.webmailer.de") by vger.kernel.org with ESMTP id ; Sat, 16 Nov 2002 13:42:51 -0500 Content-Type: text/plain; charset=US-ASCII From: Arnd Bergmann Reply-To: Arnd Bergmann To: "J.E.J. Bottomley" Subject: Re: [RFC][PATCH] move dma_mask into struct device Date: Sat, 16 Nov 2002 21:46:46 +0100 User-Agent: KMail/1.4.3 Cc: Linux Kernel , Linux Scsi References: <200211161812.gAGICj604696@localhost.localdomain> In-Reply-To: <200211161812.gAGICj604696@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Message-Id: <200211162145.44304.arndb@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 21 On Saturday 16 November 2002 19:12, J.E.J. Bottomley wrote: > No...look at what you've done. Now SCSI has to know about every bus type > on every architecture; that's an extreme layering violation. > architecture/bus types are generally only defined for the arch (PCI being > the exception), so now the additions have to be #ifdef'd just so it will > compile.. Right, the definitions for how to get the dma_mask out of a bus specific device don't belong into the generic header file. Still, each host driver knows how to find the dma_mask if any, so it can easily set the field in the Scsi_Host. Existing pci host adapter drivers can keep using scsi_set_pci_device(), others can just as well do it themselves. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/