Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbaFEDKs (ORCPT ); Wed, 4 Jun 2014 23:10:48 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:58464 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbaFEDKq (ORCPT ); Wed, 4 Jun 2014 23:10:46 -0400 MIME-Version: 1.0 In-Reply-To: <538F6DEB.2000601@redhat.com> References: <1401881699-1456-1-git-send-email-pbonzini@redhat.com> <1401881699-1456-6-git-send-email-pbonzini@redhat.com> <538F6DEB.2000601@redhat.com> Date: Wed, 4 Jun 2014 20:10:45 -0700 Message-ID: Subject: Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests From: Venkatesh Srinivas To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, hch@lst.de, JBottomley@parallels.com, stable@vger.kernel.org, Venkatesh Srinivas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/14, Paolo Bonzini wrote: > Il 04/06/2014 19:29, Venkatesh Srinivas ha scritto: >> Do you really want to poll the request VQs for completions if the TMF >> was rejected? > > I wasn't sure, but bugs in this path are hard enough that I preferred > the safer patch. Ok. As long as it was deliberate. I'd slightly prefer only doing so in the success case, but simplicity is a compelling argument :) Reviewed-by: Venkatesh Srinivas -- vs; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/