Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbaFELjY (ORCPT ); Thu, 5 Jun 2014 07:39:24 -0400 Received: from mail-qa0-f54.google.com ([209.85.216.54]:33404 "EHLO mail-qa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbaFELjW (ORCPT ); Thu, 5 Jun 2014 07:39:22 -0400 MIME-Version: 1.0 In-Reply-To: <20140605111205.GD32082@beef> References: <1400134105-3847-1-git-send-email-jaswinder.singh@linaro.org> <1400134260-3962-1-git-send-email-jaswinder.singh@linaro.org> <7978295.UBGxYvcnvH@wuerfel> <20140529154348.GH32082@beef> <20140602151454.GK32082@beef> <20140605111205.GD32082@beef> Date: Thu, 5 Jun 2014 17:09:22 +0530 Message-ID: Subject: Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox From: Jassi Brar To: Matt Porter Cc: Sudeep Holla , Jassi Brar , Arnd Bergmann , lkml , Greg Kroah-Hartman , "Anna, Suman" , Loic Pallardy , LeyFoon Tan , Craig McGeachie , Courtney Cavin , Rob Herring , Josh Cartwright , Linus Walleij , Kumar Gala , "ks.giri@samsung.com" , Devicetree List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 June 2014 16:42, Matt Porter wrote: > On Tue, Jun 03, 2014 at 03:51:55PM +0530, Jassi Brar wrote: > >> BTW, here we at least have a hardware resource to specify in the DT >> node, there are examples in kernel where the DT nodes are purely >> virtual. For ex, grep for "linux,spdif-dit". So I think we should be >> ok. >> > > There's a bit of a difference between my concern over a virtual node and > this example you've cited. In the dummy spdif transmitter, it's defining > a virtual device that plugs in for a codec, a hardware concept well > defined in the audio bindings. I agree that there are many examples of > this type of virtual node, including dummy phys, but in all cases they > are stubbing out a real hardware concept. > > I find it to be distinctly different to create a node that doesn't > represent the hardware's use of mailboxes. > The way I see "cpm_ipc" is that it represents a device that doesn't need MMIO or an IRQ, but only the mailbox hardware resource. "linux,spdif-dit" needs no hardware resource at all. So if anything, more "virtual" than cpm_ipc. > I'd be happy if a DT > maintainer could say that this is acceptable though. ;) > OK, though it becomes clear only after reading this ;) Cheers -Jassi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/