Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751507AbaFEMpR (ORCPT ); Thu, 5 Jun 2014 08:45:17 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:43785 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbaFEMpP (ORCPT ); Thu, 5 Jun 2014 08:45:15 -0400 Date: Thu, 5 Jun 2014 14:45:09 +0200 From: Ingo Molnar To: NeilBrown Cc: Peter Zijlstra , Oleg Nesterov , David Howells , Steven Whitehouse , dm-devel@redhat.com, Chris Mason , Josef Bacik , Steve French , "Theodore Ts'o" , Trond Myklebust , Ingo Molnar , Roland McGrath , Andrew Morton , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions. Message-ID: <20140605124509.GA1975@gmail.com> References: <20140501123738.3e64b2d2@notabene.brown> <20140522090502.GB30094@gmail.com> <20140522195056.445f2dcb@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140522195056.445f2dcb@notabene.brown> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * NeilBrown wrote: > On Thu, 22 May 2014 11:05:02 +0200 Ingo Molnar wrote: > > > > > * NeilBrown wrote: > > > > > [[ get_maintainer.pl suggested 61 email address for this patch. > > > I've trimmed that list somewhat. Hope I didn't miss anyone > > > important... > > > I'm hoping it will go in through the scheduler tree, but would > > > particularly like an Acked-by for the fscache parts. Other acks > > > welcome. > > > ]] > > > > > > The current "wait_on_bit" interface requires an 'action' function > > > to be provided which does the actual waiting. > > > There are over 20 such functions, many of them identical. > > > Most cases can be satisfied by one of just two functions, one > > > which uses io_schedule() and one which just uses schedule(). > > > > > > So: > > > Rename wait_on_bit and wait_on_bit_lock to > > > wait_on_bit_action and wait_on_bit_lock_action > > > to make it explicit that they need an action function. > > > > > > Introduce new wait_on_bit{,_lock} and wait_on_bit{,_lock}_io > > > which are *not* given an action function but implicitly use > > > a standard one. > > > The decision to error-out if a signal is pending is now made > > > based on the 'mode' argument rather than being encoded in the action > > > function. > > > > this patch fails to build on x86-32 allyesconfigs. > > Could you share the build errors? Sure, find it attached below. > > > > Could we keep the old names for a while, and remove them in the next > > cycle or so? > > I don't see how changing the names later rather than now will reduce the > chance of errors... maybe I'm missing something. Well, it would reduce build errors? Thanks, Ingo ====================> fs/cifs/file.c: In function ‘cifs_oplock_break’: fs/cifs/file.c:3652:4: warning: passing argument 3 of ‘wait_on_bit’ makes integer from pointer without a cast [enabled by default] cifs_pending_writers_wait, TASK_UNINTERRUPTIBLE); ^ In file included from include/linux/fs.h:6:0, from fs/cifs/file.c:24: include/linux/wait.h:878:1: note: expected ‘unsigned int’ but argument is of type ‘int (*)(void *)’ wait_on_bit(void *word, int bit, unsigned mode) ^ fs/cifs/file.c:3652:4: error: too many arguments to function ‘wait_on_bit’ cifs_pending_writers_wait, TASK_UNINTERRUPTIBLE); ^ In file included from include/linux/fs.h:6:0, from fs/cifs/file.c:24: include/linux/wait.h:878:1: note: declared here wait_on_bit(void *word, int bit, unsigned mode) ^ CC kernel/smp.o CC kernel/trace/trace_event_perf.o make[2]: *** [fs/cifs/file.o] Error 1 make[2]: *** Waiting for unfinished jobs.... CC drivers/bcma/sprom.o CC fs/btrfs/locking.o LD sound/isa/ad1848/snd-ad1848.o LD sound/isa/ad1848/built-in.o CC sound/isa/cs423x/cs4231.o CC lib/fonts/fonts.o CC lib/fonts/font_sun8x16.o CC drivers/bcma/driver_chipcommon.o CC lib/fonts/font_sun12x22.o -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/