Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751671AbaFENWr (ORCPT ); Thu, 5 Jun 2014 09:22:47 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:38632 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbaFENWp (ORCPT ); Thu, 5 Jun 2014 09:22:45 -0400 Message-ID: <53906F20.50309@mev.co.uk> Date: Thu, 5 Jun 2014 14:22:40 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Chase Southwood , CC: , , Subject: Re: [PATCH v2 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality References: <1401849124-21347-1-git-send-email-chase.southwood@gmail.com> In-Reply-To: <1401849124-21347-1-git-send-email-chase.southwood@gmail.com> Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MEVEXCHANGE.mev.local (10.0.0.4) To MEVEXCHANGE.mev.local (10.0.0.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-06-04 03:32, Chase Southwood wrote: > This patchset introduces a new private data struct for this driver, adds > all of the code required to support Change-of-State interrupts for the > digital input subdevice, and finally fixes > apci1564_interrupt() to service this type of interrupt correctly. > > CHANGES FROM v1: > *leave the send_sig() calls in for now, until the proper replacement can > be implemented. > *removed unused static globals, removed the remaining one into the private > data struct. > *private data struct moved into addi_apci_1564.c. > *patches 4/6 and 5/6 from v1 have been merged into patch 4/5 here. > *(*cancel) for the interrupt subdevice has been reduced to just disable DI > interrupts rather than using the board's reset function. > *support for all interrupts issued by the board has been kept in > apci1564_interrupt(), rather than stripping everything out except for DI > interrupt support. However, DI interrupt support has still been fixed. > > Chase Southwood (5): > staging: comedi: addi_apci_1564: remove use of > devpriv->b_OutputMemoryStatus > staging: comedi: addi_apci_1564: remove unused static variables > staging: comedi: addi_apci_1564: introduce apci1564_private struct > staging: comedi: addi_apci_1564: add Change-of-State interrupt > subdevice and required functions > staging: comedi: addi_apci_1564: move apci1564_interrupt() into > addi_apci_1564.c > > .../comedi/drivers/addi-data/hwdrv_apci1564.c | 304 +++------------ > drivers/staging/comedi/drivers/addi_apci_1564.c | 433 +++++++++++++++++++-- > 2 files changed, 454 insertions(+), 283 deletions(-) > Looks good! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/