Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbaFENm5 (ORCPT ); Thu, 5 Jun 2014 09:42:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbaFENmz (ORCPT ); Thu, 5 Jun 2014 09:42:55 -0400 From: Igor Mammedov To: linux-kernel@vger.kernel.org Cc: mingo@redhat.com, x86@kernel.org Subject: [PATCH v6 2/3] x86: log error on secondary CPU wakeup failure at ERR level Date: Thu, 5 Jun 2014 15:42:44 +0200 Message-Id: <1401975765-22328-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1401975765-22328-1-git-send-email-imammedo@redhat.com> References: <1401975765-22328-1-git-send-email-imammedo@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If system is running without debug level logging, it will not log error if do_boot_cpu() failed to wakeup AP. It may lead to silent AP bringup failures at boot time. Change message level to KERN_ERR to make error visible to user as it's done on other architectures. Signed-off-by: Igor Mammedov Acked-by: Toshi Kani --- arch/x86/kernel/smpboot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 2988f69..ae2fd97 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -918,7 +918,7 @@ int native_cpu_up(unsigned int cpu, struct task_struct *tidle) err = do_boot_cpu(apicid, cpu, tidle); if (err) { - pr_debug("do_boot_cpu failed %d\n", err); + pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); return -EIO; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/