Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbaFEPEo (ORCPT ); Thu, 5 Jun 2014 11:04:44 -0400 Received: from terminus.zytor.com ([198.137.202.10]:49211 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbaFEPEn (ORCPT ); Thu, 5 Jun 2014 11:04:43 -0400 Message-ID: <539086F6.8000004@zytor.com> Date: Thu, 05 Jun 2014 08:04:22 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Nadav Amit , Paolo Bonzini CC: Nadav Amit , gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] KVM: x86: smsw emulation is incorrect in 64-bit mode References: <1401723251-8034-1-git-send-email-namit@cs.technion.ac.il> <1401723251-8034-10-git-send-email-namit@cs.technion.ac.il> <53908467.8030100@redhat.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/2014 08:02 AM, Nadav Amit wrote: >> I'm sorry, I'm missing the place where 64-bit mode is taken into account? > It is not, since on 32-bit mode the high-order 16 bits of a register destination are undefined. > If I recall correctly, in this case the high-order 16-bits on native system actually reflect the high-order 16-bits of CR0. This sounds like something that really should be verified experimentally. The above claim seems... odd. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/