Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484AbaFEPRX (ORCPT ); Thu, 5 Jun 2014 11:17:23 -0400 Received: from vegas.theobroma-systems.com ([144.76.126.164]:54128 "EHLO mail.theobroma-systems.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbaFEPRW (ORCPT ); Thu, 5 Jun 2014 11:17:22 -0400 From: Marcus Nutzinger To: Felipe Balbi Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Sergei Shtylyov , Marcus Nutzinger Subject: [PATCH v2] usb: gadget: gadgetfs: correct dev state Date: Thu, 5 Jun 2014 17:17:06 +0200 Message-Id: <1401981426-20505-1-git-send-email-marcus.nutzinger@theobroma-systems.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1401973680-18413-1-git-send-email-marcus.nutzinger@theobroma-systems.com> References: <1401973680-18413-1-git-send-email-marcus.nutzinger@theobroma-systems.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 1826e9b1 (usb: gadget: gadgetfs: use after free in dev_release()) and places the call to put_dev() after setting the state. If this is not the final call to dev_release() and the state is not reset to STATE_DEV_DISABLED and hence all further open() calls to the gadgetfs ep0 device will fail with EBUSY. Signed-off-by: Marcus Nutzinger Reviewed-by: Christoph Muellner --- drivers/usb/gadget/inode.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c index a925d0c..6330528 100644 --- a/drivers/usb/gadget/inode.c +++ b/drivers/usb/gadget/inode.c @@ -1264,8 +1264,13 @@ dev_release (struct inode *inode, struct file *fd) kfree (dev->buf); dev->buf = NULL; - put_dev (dev); + /* other endpoints were all decoupled from this device */ + spin_lock_irq(&dev->lock); + dev->state = STATE_DEV_DISABLED; + spin_unlock_irq(&dev->lock); + + put_dev (dev); return 0; } -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/