Content-Type: text/plain; charset=US-ASCII
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: [PATCH] usb: gadget: gadgetfs: correct dev state
From: Marcus Nutzinger <marcus.nutzinger@theobroma-systems.com>
In-Reply-To: <53907C23.5060404@cogentembedded.com>
Date: Thu, 5 Jun 2014 17:15:02 +0200
Cc: Felipe Balbi <balbi@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 7BIT
Message-Id: <5A6C89E5-92AB-4908-8867-2BE783794E60@theobroma-systems.com>
References: <1401973680-18413-1-git-send-email-marcus.nutzinger@theobroma-systems.com> <53907C23.5060404@cogentembedded.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sender: linux-kernel-owner@vger.kernel.org

Hi Sergei,

On Jun 5, 2014, at 4:18 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:

>   Please also specify that commit's summary line in parens.

I'll resubmit the updated patch in a minute!

>> +	/* other endpoints were all decoupled from this device */
>> +	spin_lock_irq(&dev->lock);
>> +	dev->state = STATE_DEV_DISABLED;
>> +	spin_unlock_irq(&dev->lock);
> 
>   Not sure I understand why you need spinlock here... isn't the assignment atomic already?


Sure, an assignment might be atomic. However, following the policy of commit 7489d149
(USB: gadgetfs cleanups) all ep0 state changes shall be protected by spinlocks.

Thanks,
Marcus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/