Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbaFER5d (ORCPT ); Thu, 5 Jun 2014 13:57:33 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:59684 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbaFER5b (ORCPT ); Thu, 5 Jun 2014 13:57:31 -0400 Message-ID: <5390AF88.9050007@wwwdotorg.org> Date: Thu, 05 Jun 2014 11:57:28 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Peter De Schrijver CC: Russell King , Thierry Reding , Andrew Morton , Linus Walleij , Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/5] ARM: tegra: export apb dma readl/writel References: <1401973754-19701-1-git-send-email-pdeschrijver@nvidia.com> <1401973754-19701-2-git-send-email-pdeschrijver@nvidia.com> In-Reply-To: <1401973754-19701-2-git-send-email-pdeschrijver@nvidia.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/2014 07:09 AM, Peter De Schrijver wrote: > Export APB DMA readl and writel. These are needed because we can't access > the fuses directly on Tegra20 without potentially causing a system hang. > Also have the APB DMA readl and writel return an error in case of a read > failure instead of just returning zero or ignore write failures. > diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h > +int tegra_apb_readl_using_dma(unsigned long offset, u32 *value); > +int tegra_apb_writel_using_dma(u32 value, unsigned long offset); Hmm. I wonder why we're exporting those low-level internal functions rather than the higher-level tegra_apb_readl()/writel() wrappers that "clients" are supposed to be using. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/