Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbaFEUVM (ORCPT ); Thu, 5 Jun 2014 16:21:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12282 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbaFEUVL (ORCPT ); Thu, 5 Jun 2014 16:21:11 -0400 Date: Thu, 5 Jun 2014 17:21:02 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Stephane Eranian , LKML , Namhyung Kim , David Ahern , Peter Zijlstra , "mingo@elte.hu" Subject: Re: [PATCH] perf tools: Fix pipe check regression in attr event callback Message-ID: <20140605202102.GE2311@infradead.org> References: <20140605170011.GA13372@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140605170011.GA13372@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jun 05, 2014 at 07:00:11PM +0200, Jiri Olsa escreveu: > On Thu, Jun 05, 2014 at 06:06:41PM +0200, Stephane Eranian wrote: > > Hi Jiri, > > > > Somehow, I thought you had written a fix to avoid the problem below. > > But when I try with tip.git, the problem is still there. > > Could you push your fix ASAP. > > > > Thanks. > > > > $ perf record -o - noploop 2 | perf inject -b | perf report -i - > > # To display the perf.data header info, please use > > --header/--header-only options. > > # > > noploop for 2 seconds > > 0x1bd0 [0x28]: failed to process type: 9 > > hum, I remember fixing another issue.. this one is > separated one, please try attached patch. > > thanks, > jirka > > > --- > The file factoring in builtin-inject.c object introduced regression > in attr event callback. The commit is: > 3406912 perf inject: Handle output file via perf_data_file object > > Following hunk reversed the logic: > - if (!inject->pipe_output) > + if (&inject->output.is_pipe) Why do we need this '&'? this will always evaluate to true, as it will get the address of a variable, also adding a ! before it will just it eval to false always, or am I missing something? :-) I think this should really be: if (!inject->output.is_pipe) No? - Arnaldo > > putting it back, following example now works: > $ perf record -o - kill | perf inject -b | perf report -i - > > Reported-by: Stephane Eranian > Cc: Arnaldo Carvalho de Melo > Cc: Corey Ashford > Cc: David Ahern > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > Signed-off-by: Jiri Olsa > --- > tools/perf/builtin-inject.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c > index 6a3af00..664010b 100644 > --- a/tools/perf/builtin-inject.c > +++ b/tools/perf/builtin-inject.c > @@ -72,7 +72,7 @@ static int perf_event__repipe_attr(struct perf_tool *tool, > if (ret) > return ret; > > - if (&inject->output.is_pipe) > + if (!&inject->output.is_pipe) > return 0; > > return perf_event__repipe_synth(tool, event); > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/