Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbaFFJ4j (ORCPT ); Fri, 6 Jun 2014 05:56:39 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:38556 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbaFFJ4h (ORCPT ); Fri, 6 Jun 2014 05:56:37 -0400 Message-ID: <5391903B.1050109@ti.com> Date: Fri, 6 Jun 2014 15:26:11 +0530 From: George Cherian User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Nishanth Menon , , CC: , , , Subject: Re: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm References: <1402035454-25676-1-git-send-email-george.cherian@ti.com> <53916556.10608@ti.com> <539165E8.7030500@ti.com> In-Reply-To: <539165E8.7030500@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/6/2014 12:25 PM, Nishanth Menon wrote: > On 06/06/2014 01:53 AM, Nishanth Menon wrote: >> On 06/06/2014 01:17 AM, George Cherian wrote: >>> AM437x EPOS evm use external clock for RMII interface. >>> Enable the same in DT. >>> >>> Signed-off-by: George Cherian >>> Reported-by: Nishanth Menon >>> --- >>> arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts >>> index 19f1f7e..90098f9 100644 >>> --- a/arch/arm/boot/dts/am43x-epos-evm.dts >>> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts >>> @@ -319,6 +319,10 @@ >>> phy-mode = "rmii"; >>> }; >>> >>> +&phy_sel { >>> + rmii-clock-ext; >>> +}; >>> + >>> &i2c0 { >>> status = "okay"; >>> pinctrl-names = "default"; >>> >> Where does this apply on? >> With linux-next next-20140506 tag, and this patch applied, I get the >> following error. >> >> LD kernel/trace/built-in.o >> LD kernel/built-in.o >> build fail, Error: >> Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path, >> 'phy_sel', not found >> FATAL ERROR: Syntax error parsing input tree >> make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [dtbs] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> in the future, it is helpful if you can point out that this is a >> regression seen on next-20140603 and the patch needs to be applied on >> some specific branch. >> >> for the record: >> last working next tag: >> https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt >> >> first broken next tag: >> https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt >> >> > interestingly, i just re-tested today's tag without the patch > (omap2plus_defconfig): > http://slexy.org/raw/s205sRdFvy Lil old kernel from the above link. Linux version 3.15.0-rc4-next-20140506 (nmenon@kahuna) (gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #2 SMP Fri Jun 6 01:47:42 CDT 2014 > I wonder why the behavior change and what was being fixed here? This kernel should not have the dt entries for phy sel driver. Thats why it is working. -- -George -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/