Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbaFFQr1 (ORCPT ); Fri, 6 Jun 2014 12:47:27 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:57645 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbaFFQr0 (ORCPT ); Fri, 6 Jun 2014 12:47:26 -0400 MIME-Version: 1.0 In-Reply-To: <1402071320-14400-11-git-send-email-navin.patidar@gmail.com> References: <1402071320-14400-1-git-send-email-navin.patidar@gmail.com> <1402071320-14400-11-git-send-email-navin.patidar@gmail.com> Date: Fri, 6 Jun 2014 22:17:25 +0530 Message-ID: Subject: Re: [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code From: navin patidar To: Greg KH Cc: Larry Finger , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Rickard Strandqvist Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sorry, my script picked up Rickard's patch and send it out again along my patches. I need to fix my script. regards, navin patidar On Fri, Jun 6, 2014 at 9:45 PM, navin patidar wrote: > From: Rickard Strandqvist > > Removes unnecessary code that does not do anything useful. > > This was partly found using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > index 2e49cd5..fb3789e 100644 > --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > @@ -563,14 +563,8 @@ static int rtw_resume(struct usb_interface *pusb_intf) > { > struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf); > struct adapter *padapter = dvobj->if1; > - struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv; > - int ret = 0; > > - if (pwrpriv->bInternalAutoSuspend) > - ret = rtw_resume_process(padapter); > - else > - ret = rtw_resume_process(padapter); > - return ret; > + return rtw_resume_process(padapter); > } > > int rtw_resume_process(struct adapter *padapter) > -- > 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/