Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbaFFSxM (ORCPT ); Fri, 6 Jun 2014 14:53:12 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:56190 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbaFFSxL (ORCPT ); Fri, 6 Jun 2014 14:53:11 -0400 MIME-Version: 1.0 In-Reply-To: <1402080068.14433.5.camel@buesod1.americas.hpqcorp.net> References: <5390D7E1.7060606@gatech.edu> <5391FFFD.1060901@gatech.edu> <20140606175655.GX13930@laptop.programming.kicks-ass.net> <1402080068.14433.5.camel@buesod1.americas.hpqcorp.net> From: Pranith Kumar Date: Fri, 6 Jun 2014 14:52:40 -0400 X-Google-Sender-Auth: FMYmBsOzHnoM5bUsfv8n7Q-C0FM Message-ID: Subject: Re: [RFC PATCH 1/1] cleanup: use bool as return type for rwsem_is_locked To: Davidlohr Bueso Cc: Peter Zijlstra , LKML , tim.c.chen@linux.intel.com, mingo@redhat.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 6, 2014 at 2:41 PM, Davidlohr Bueso wrote: > On Fri, 2014-06-06 at 19:56 +0200, Peter Zijlstra wrote: >> On Fri, Jun 06, 2014 at 01:53:01PM -0400, Pranith Kumar wrote: >> > On Fri, Jun 6, 2014 at 3:35 AM, Peter Zijlstra wrote: >> > > >> > > Now in general, I don't particularly like such superfluous changes, so >> > > unless you can show that GCC actually generates better code, I'd prefer >> > > to keep things as they are. >> > >> > Fixed and checked the assembly. It saves us 2 bytes of code, not much. I am not sure if that is worth it :( >> >> still 2 bytes, so sure. >> >> Which gcc did you use and what arch did you build? That might be useful >> info for the changelog. > > Yeah, please attach the output of 'size kernel/locking/rwsem.o' for both > before and after. I think there's similar opportunity in other locking > code as well. > Ok. Here is the data. size kernel/locking/rwsem-spinlock.o Before change to bool: text data bss dec hex 1336 0 0 1336 538 After change to bool: text data bss dec hex 1334 0 0 1334 536 -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/