Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbaFFTGK (ORCPT ); Fri, 6 Jun 2014 15:06:10 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:40382 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbaFFTGI (ORCPT ); Fri, 6 Jun 2014 15:06:08 -0400 Message-ID: <53921116.5050804@oracle.com> Date: Fri, 06 Jun 2014 15:05:58 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jan Kara , Peter Hurley CC: pmladek@suse.cz, Andrew Morton , Jet Chen , LKML Subject: Re: console: lockup on boot References: <5388838B.8070802@oracle.com> <53888E76.5040101@hurleysoftware.com> <20140530140757.GC2419@quack.suse.cz> In-Reply-To: <20140530140757.GC2419@quack.suse.cz> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2014 10:07 AM, Jan Kara wrote: > On Fri 30-05-14 09:58:14, Peter Hurley wrote: >> > On 05/30/2014 09:11 AM, Sasha Levin wrote: >>> > >Hi all, >>> > > >>> > >I sometime see lockups when booting my KVM guest with the latest -next kernel, >>> > >it basically hangs right when it should start 'init', and after a while I get >>> > >the following spew: >>> > > >>> > >[ 30.790833] BUG: spinlock lockup suspected on CPU#1, swapper/1/0 >> > >> > Maybe related to this report: https://lkml.org/lkml/2014/5/30/26 >> > from Jet Chen which was bisected to >> > >> > commit bafe980f5afc7ccc693fd8c81c8aa5a02fbb5ae0 >> > Author: Jan Kara >> > AuthorDate: Thu May 22 10:43:35 2014 +1000 >> > Commit: Stephen Rothwell >> > CommitDate: Thu May 22 10:43:35 2014 +1000 >> > >> > printk: enable interrupts before calling console_trylock_for_printk() >> > We need interrupts disabled when calling console_trylock_for_printk() only >> > so that cpu id we pass to can_use_console() remains valid (for other >> > things console_sem provides all the exclusion we need and deadlocks on >> > console_sem due to interrupts are impossible because we use >> > down_trylock()). However if we are rescheduled, we are guaranteed to run >> > on an online cpu so we can easily just get the cpu id in >> > can_use_console(). >> > We can lose a bit of performance when we enable interrupts in >> > vprintk_emit() and then disable them again in console_unlock() but OTOH it >> > can somewhat reduce interrupt latency caused by console_unlock() >> > especially since later in the patch series we will want to spin on >> > console_sem in console_trylock_for_printk(). >> > Signed-off-by: Jan Kara >> > Signed-off-by: Andrew Morton >> > >> > ? > Yeah, very likely. I think I see the problem, I'll send the fix shortly. Hi Jan, It seems that the issue I'm seeing is different from the "[prink] BUG: spinlock lockup suspected on CPU#0, swapper/1". Is there anything else I could try here? The issue is very common during testing. Thanks, Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/