Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752242AbaFFUhG (ORCPT ); Fri, 6 Jun 2014 16:37:06 -0400 Received: from mail-ve0-f177.google.com ([209.85.128.177]:34468 "EHLO mail-ve0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbaFFUhE (ORCPT ); Fri, 6 Jun 2014 16:37:04 -0400 MIME-Version: 1.0 In-Reply-To: <1402082953.28220.7.camel@ceramic.home.fifi.org> References: <1402082953.28220.7.camel@ceramic.home.fifi.org> Date: Fri, 6 Jun 2014 16:37:03 -0400 Message-ID: Subject: Re: Phantom ACL-related xattrs on 3.14.4 NFS client From: Trond Myklebust To: Philippe Troin , Christoph Hellwig Cc: Linux NFS Mailing List , Linux Kernel mailing list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 6, 2014 at 3:29 PM, Philippe Troin wrote: > This happens on an NFS client running on: > Linux ceramic32 3.14.4 #1 SMP Fri May 30 00:52:07 PDT 2014 i686 i686 i386 GNU/Linux > (also happens on x86_64). > > The NFS server can be either 3.14 or 3.13, it doesn't change a thing. > > Mount options are: > (from /proc/mtab) > ceramic:/export/home/phil /home/phil nfs rw,nosuid,nodev,relatime,vers=3,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=172.17.1.2,mountvers=3,mountport=20048,mountproto=tcp,local_lock=none,addr=172.17.1.2 0 0 > (This is NFSv3) > > The symptom: > > Run getfacl on any NFS inode. See there are no ACLs: > > % getfacl . > # file: . > # owner: phil > # group: phil > user::rwx > group::r-x > other::r-x > > Yet, getfattr says there are some acl-related xattrs: > > % getfattr -m '.*' . > # file: . > system.posix_acl_access > system.posix_acl_default > > But when you want to retrieve these phantom xattrs, I get errors: > > % getfattr -n system.posix_acl_access . > .: system.posix_acl_access: No such attribute > [1] 1136 exit 1 getfattr -n system.posix_acl_access . > % getfattr -n system.posix_acl_default . > .: system.posix_acl_default: No such attribute > [1] 1146 exit 1 getfattr -n system.posix_acl_default . > > I've noticed because it breaks the patch utility. > > This is a regression from 3.13, probably due to the 3.14 NFS ACL overhaul. > Christoph, what is the intended interface for telling posix_acl_xattr_list() that there are no acls on a particular file? Should there perhaps be a call to get_acl()? -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/