Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbaFFVKR (ORCPT ); Fri, 6 Jun 2014 17:10:17 -0400 Received: from mail-ve0-f171.google.com ([209.85.128.171]:49749 "EHLO mail-ve0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbaFFVKP (ORCPT ); Fri, 6 Jun 2014 17:10:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <201406042235.s54MZgwP020553@terminus.zytor.com> <20140606140017.afb7f91142f66cb3dd13c186@linux-foundation.org> From: Andy Lutomirski Date: Fri, 6 Jun 2014 14:09:54 -0700 Message-ID: Subject: Re: [GIT PULL] x86/vdso changes for v3.16 To: Linus Torvalds Cc: Andrew Morton , "H. Peter Anvin" , Cyrill Gorcunov , Peter Anvin , Linux Kernel Mailing List , Ingo Molnar , Sasha Levin , Stefani Seibold , Thomas Gleixner , Pavel Emelyanov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 6, 2014 at 2:07 PM, Linus Torvalds wrote: > On Fri, Jun 6, 2014 at 2:00 PM, Andrew Morton wrote: >> >> arch/x86/vdso/vdso2c.h: In function 'go64': >> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le64toh' >> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le32toh' >> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le16toh' >> arch/x86/vdso/vdso2c.h:119: warning: implicit declaration of function 'htole16' >> >> My Fedora Core 6 (lol gotcha) test box doesn't have these. > > Suggested fix: only use the helper functions on non-x86 (or > non-little-endian) platforms. > > Peter, Andy? The only real downside to that would be the chance of bitrot if that code isn't getting used on native builds. Blech. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/