MIME-Version: 1.0
In-Reply-To: <53922F74.20406@linux.intel.com>
References: <201406042235.s54MZgwP020553@terminus.zytor.com>
 <20140606140017.afb7f91142f66cb3dd13c186@linux-foundation.org>
 <CA+55aFyKTbBUM4DJukmW5fiH213D0FbVmrreR9wOtMRmmijQ9Q@mail.gmail.com>
 <CALCETrWA92Q4ro9eaRkUrebjgQT7B2uj+bK81m9byZnDY_eMxA@mail.gmail.com>
 <CA+55aFx8ezbe-mCYWp6kM8Nh3oUQd_+SNz6mLoGQtMVDk3EALA@mail.gmail.com> <53922F74.20406@linux.intel.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Fri, 6 Jun 2014 14:22:12 -0700
Message-ID: <CALCETrXpCMdyPjM6MSbxoi0matoYLfduuSiwmTjGCUU62KOsTw@mail.gmail.com>
Subject: Re: [GIT PULL] x86/vdso changes for v3.16
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Cyrill Gorcunov <gorcunov@openvz.org>, Peter Anvin <hpa@zytor.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Sasha Levin <sasha.levin@oracle.com>,
        Stefani Seibold <stefani@seibold.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Pavel Emelyanov <xemul@parallels.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Jun 6, 2014 at 2:15 PM, H. Peter Anvin <hpa@linux.intel.com> wrote:
> On 06/06/2014 02:13 PM, Linus Torvalds wrote:
>> On Fri, Jun 6, 2014 at 2:09 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>>
>>> The only real downside to that would be the chance of bitrot if that
>>> code isn't getting used on native builds.
>>
>> Sure. Does anybody really care?
>>
>> You could obviously just open-code the things, but the fact is,
>> "le64toh()" isn't exactly a standard function anyway, so now that I
>> see it needed I go "yeah, that's clearly completely unacceptable".
>>
>> I'd much rather say "screw cross-compiling" (because let's face it,
>> nobody sane cross-compiles x86 on anything else) than say "screw old
>> machines".
>>
>
> I'm thinking we should just carry the support functions with us, we
> already have some of those in tools/include.  Working on a patchset for
> this.

Sounds good.

In the mean time, a trivial fix is here:

https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=vdso/cleanup_fixes&id=cf780a0dc71f7cbd9a417e6ce2d5ddf56abccb74

(or it will be once the mirrors sync)

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/