Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S267610AbSKQVs3>; Sun, 17 Nov 2002 16:48:29 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S267607AbSKQVs3>; Sun, 17 Nov 2002 16:48:29 -0500
Received: from leibniz.math.psu.edu ([146.186.130.2]:46214 "EHLO math.psu.edu")
	by vger.kernel.org with ESMTP id <S266959AbSKQVs1>;
	Sun, 17 Nov 2002 16:48:27 -0500
Date: Sun, 17 Nov 2002 16:55:26 -0500 (EST)
From: Alexander Viro <viro@math.psu.edu>
To: Linus Torvalds <torvalds@transmeta.com>
cc: Doug Ledford <dledford@redhat.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Linux Scsi Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: Several Misc SCSI updates...
In-Reply-To: <Pine.LNX.4.44.0211171338570.12975-100000@home.transmeta.com>
Message-ID: <Pine.GSO.4.21.0211171653391.23400-100000@steklov.math.psu.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 991
Lines: 25



On Sun, 17 Nov 2002, Linus Torvalds wrote:

> 
> On Sun, 17 Nov 2002, Doug Ledford wrote:
> > 
> > Won't work.  module->live is what Rusty uses to indicate that the module 
> > is in the process of unloading, which is when we *do* want the attempt to 
> > module_get() to fail.
> 
> That's fine, as long as "module_get()" is the only thing that cares. Just 
> make it go "live" early as you indicate, and everybody should be happy. I 
> certainly agree that it should be illegal to do more module_get()'s once 
> we've already started unloading..

On the unload side it's OK.  module_get() also breaks during _init_ and that's
the problem.  IOW, you'll need to make every block device driver to set ->live
manually.  Smells like a wrong API...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/