Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753993AbaFIBrb (ORCPT ); Sun, 8 Jun 2014 21:47:31 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:65110 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753512AbaFIBrX (ORCPT ); Sun, 8 Jun 2014 21:47:23 -0400 MIME-Version: 1.0 In-Reply-To: References: <20110724011752.GA14373@gondor.apana.org.au> <20111031040952.GA19659@gondor.apana.org.au> <20120106041250.GA7759@gondor.apana.org.au> <20121004095357.GA11777@gondor.apana.org.au> <20121214103156.GA5840@gondor.apana.org.au> <20130223023331.GA11002@gondor.apana.org.au> <20130907035544.GA22658@gondor.apana.org.au> <20131107080131.GA32307@gondor.apana.org.au> <20140123115319.GA20602@gondor.apana.org.au> <20140401100001.GA12386@gondor.apana.org.au> <20140605062336.GA14440@gondor.apana.org.au> Date: Mon, 9 Jun 2014 09:47:23 +0800 Message-ID: Subject: Re: Crypto Update for 3.16 From: Steven Miao To: Linus Torvalds Cc: Herbert Xu , Sonic Zhang , "David S. Miller" , Linux Kernel Mailing List , Linux Crypto Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On Sun, Jun 8, 2014 at 10:56 AM, Linus Torvalds wrote: > On Wed, Jun 4, 2014 at 11:23 PM, Herbert Xu wrote: >> >> Here is the crypto update for 3.16: > > There's something odd going on with bfin_crc.h. > > You moved it in commit 52e6e543f2d8 ("crypto: bfin_crc - access crc > registers by readl and writel functions"). > > It got *deleted* by commit 3356c99ea392 ("bfin_crc: Move architecture > independant crc header file out of the blackfin folder") which claims > to just move things. > > Both of those commits are by Sonic Zhang, just came to me through two > different trees (though your crypto tree, and through Steven Miao's > bfin tree). > > I'm assuming that the delete was actually incorrect, and should have > been a move, because it looks like the bfin_crc.c file won't compile > without it. So I've re-instated that file. > > But the state of the bfin tree seems to be crap. Somebody should take > a look at what happened here. My suspicion is that commit 3356c99ea392 > was broken by Steven Miao trying to only touch files in arch/blackfin > or something. Yes. I should be a move from arch/blackfin to drivers/crypto, sorry for I only formating the arch/blackfin changes. > > Linus -steven -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/