Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752894AbaFIGAs (ORCPT ); Mon, 9 Jun 2014 02:00:48 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:37152 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbaFIGAq convert rfc822-to-8bit (ORCPT ); Mon, 9 Jun 2014 02:00:46 -0400 MIME-Version: 1.0 X-Originating-IP: [80.196.35.44] In-Reply-To: References: <1402057225-7312-1-git-send-email-m@bjorling.me> <1402057225-7312-2-git-send-email-m@bjorling.me> Date: Mon, 9 Jun 2014 08:00:45 +0200 Message-ID: Subject: Re: [PATCH v6] NVMe: conversion to blk-mq From: =?UTF-8?Q?Matias_Bj=C3=B8rling?= To: Ming Lei Cc: Matthew Wilcox , Keith Busch , "Sam Bradshaw (sbradshaw)" , Jens Axboe , Linux Kernel Mailing List , linux-nvme@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 9, 2014 at 6:35 AM, Ming Lei wrote: > On Fri, Jun 6, 2014 at 8:20 PM, Matias Bjørling wrote: >> This converts the current NVMe driver to utilize the blk-mq layer. > > Looks it can't be applied cleanly against 3.15-rc8 + Jens's for-linux > branch, when I fix the conflict manually, below failure is triggered: > > [ 487.696057] nvme 0000:00:07.0: Cancelling I/O 202 QID 1 > [ 487.699005] nvme 0000:00:07.0: Aborting I/O 202 QID 1 > [ 487.704074] nvme 0000:00:07.0: Cancelling I/O 202 QID 1 > [ 487.717881] nvme 0000:00:07.0: Aborting I/O 202 QID 1 > [ 487.736093] end_request: I/O error, dev nvme0n1, sector 91532352 > [ 487.747378] nvme 0000:00:07.0: completed id 0 twice on queue 0 > > > when running fio randread(libaio, iodepth:64) with more than 3 jobs. > > And looks no such failure when jobs is 1 or 2. Can you try with the nvmemq_review branch at https://github.com/MatiasBjorling/linux-collab.git I'll take a look tomorrow and see if I can reproduce it. Thanks! > > Thanks, > -- > Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/