Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754301AbaFIUK1 (ORCPT ); Mon, 9 Jun 2014 16:10:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43384 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753960AbaFIUKX (ORCPT ); Mon, 9 Jun 2014 16:10:23 -0400 Message-ID: <539614AA.3040409@suse.com> Date: Mon, 09 Jun 2014 16:10:18 -0400 From: Jeff Mahoney User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Linus Torvalds , Jan Kara CC: linux-fsdevel , "linux-ext4@vger.kernel.org" , LKML Subject: Re: [GIT PULL] Reiserfs & ext3 changes for 3.16-rc1 References: <20140604202758.GC22927@quack.suse.cz> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 6/7/14, 7:52 PM, Linus Torvalds wrote: > On Wed, Jun 4, 2014 at 1:27 PM, Jan Kara wrote: >> Hello Linus, >> >> could you please pull from >> >> git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git >> for_linus >> >> to get big reiserfs cleanup from Jeff, an ext3 deadlock fix, and >> some small cleanups. > > This does not work at all for me: > > fs/reiserfs/do_balan.c: In function ‘balance_leaf_new_nodes’: > fs/reiserfs/do_balan.c:1248:3: error: implicit declaration of > function ‘format_bh’ [-Werror=implicit-function-declaration] > RFALSE(!buffer_journaled(tb->S_new[i]) ^ > > Hmm? "format_bh()"? Weird. That's part of a follow-on patchset. One of the patches gets rid of do_reiserfs_warning printing into a static buffer w/o a lock. I must've forgotten a 'quilt add' when adding that chunk to the newer patch. I'll review what else, if anything, might've changed but for now, that should be be s/format_bh(tb->S_new[i])/tb->S_new[i]/. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQIcBAEBAgAGBQJTlhSqAAoJEB57S2MheeWyy+IP/iYBJbocG4hF8364ognOfyX+ Q1wEzuNvRbZkplNueI1spfvdSJdJ2xMkWYXhaX2WwjQtG+pibLTUbFe8fgEh4egL 0yxtkENeJye0RsCJVALH25iu3iL0u6e03phM6FyvgkRra1jOWSMXJTAlV8ZpQs3o EXBQ5qoojOaWc3yGmYEugXkLOp5JyJZn0S9EbWqBKw9v8e01kz1zxzfUAoiYb6Ug hhoXiP2MOhTsgGgMJcCuk2cPNZ2CmHBlv++hGmyA/Dbne1oi+TacaHilwXI2xNI+ fU0IgSVdVC4avZDXXAXLbz0oBLz4/ba/OIiFN8htipNU9wUBJ+GFawpEZIqZ8iTz WEptpUhcjZdc2SXJxuajjf2Am4VmTt3Rv/wg8kvopD0ANT9sJxLPuKENFqqiusVe ugE7tL4JkHbz4vm4cbNu3YP7LfXtq/s3EpwiW5SJMVcKURaOriyYrOYbdJ73yKwb P1K7sj+z3zKmPVuRrbDOgyVKMP1xxb8/ockJVawRUx4vZcn08Nu5f7ZofPewW/mT XVHDe+YFC+IGLqJwudE0j6O6ZAWZTt1uJeg6IoFenuJhZACZiT/dhR2r5z/kCclk 0VFpLhKR+xy8Q7BB3gDWYZ/NFS7RA8gEu0pbIOj36LUyERX4UeUOsH+oWYoxLvwj sazZbiauomfvBVZxu4+f =4Lqx -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/