Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387AbaFIVH2 (ORCPT ); Mon, 9 Jun 2014 17:07:28 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:56215 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932226AbaFIVHY (ORCPT ); Mon, 9 Jun 2014 17:07:24 -0400 Date: Mon, 9 Jun 2014 14:07:22 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Stratos Karafotis cc: "Rafael J. Wysocki" , Viresh Kumar , Dirk Brandewie , "linux-pm@vger.kernel.org" , LKML Subject: Re: [PATCH 7/7] cpufreq: intel_pstate: Make intel_pstate_kobject local In-Reply-To: <53962096.1060202@semaphore.gr> Message-ID: References: <53962096.1060202@semaphore.gr> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jun 2014, Stratos Karafotis wrote: > Since we never remove sysfs entry, we can make the intel_pstate_kobject > local. > For even more savings, this function and intel_pstate_debug_expose_params() can be annotated with __init and freed after bootstrap. > Signed-off-by: Stratos Karafotis > --- > drivers/cpufreq/intel_pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index fa44f0f..9533fff 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -387,10 +387,10 @@ static struct attribute *intel_pstate_attributes[] = { > static struct attribute_group intel_pstate_attr_group = { > .attrs = intel_pstate_attributes, > }; > -static struct kobject *intel_pstate_kobject; > > static void intel_pstate_sysfs_expose_params(void) > { > + struct kobject *intel_pstate_kobject; > int rc; > > intel_pstate_kobject = kobject_create_and_add("intel_pstate", -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/